Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the compile flags for vcpkg packages #23455

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Update the compile flags for vcpkg packages #23455

merged 1 commit into from
Jan 22, 2025

Conversation

snnn
Copy link
Member

@snnn snnn commented Jan 22, 2025

Description

This PR updates the triplets files that manage the compile flags for vcpkg packages.
All the changes are autogenerated except for the gen.py file in this PR.

Main changes:

  1. Enable debug info for all Linux build config(Release and Debug)
  2. Set CMAKE_CXX_STANDARD in each triplet. The value is set to 20 for macOS targets and 17 for the others.
  3. Only set _FORTIFY_SOURCE in release build. This is to address a build issue on some platforms with the following glibc change:
    "Warn if user requests __FORTIFY_SOURCE but it is disabled"
    https://sourceware.org/git/?p=glibc.git;a=commit;f=include/features.h;h=05c2c9618f583ea4acd69b3fe5ae2a2922dd2ddc

Motivation and Context

Address a Linux build error.

@snnn snnn merged commit 3dcc901 into main Jan 22, 2025
98 checks passed
@snnn snnn deleted the snnn/vcpkg_triplets branch January 22, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants