[WebGPU] Support PIX Capture for WebGPU EP #23192
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PIX Capture tool requires 'present' to end a frame capture. ORT doesn't have rendering work so no 'present' happens. To avoid endless waiting for PIX capture tool, this PR added a blank surface and 'present' on it in each session run. The surface is created in WebGPU ep constructor and closed in WebGPU ep destructor.
|
@microsoft-github-policy-service agree [company="Microsoft"] |
|
@microsoft-github-policy-service agree |
shaoboyan091
changed the title
fs-eire
reviewed
Jan 2, 2025
fs-eire
reviewed
Jan 2, 2025
fs-eire
reviewed
Jan 2, 2025
|
@fs-eire Please take another look, thanks! |
There was a problem hiding this comment.
Copilot reviewed 1 out of 9 changed files in this pull request and generated no comments.
Files not reviewed (8)
- cmake/CMakeLists.txt: Language not supported
- cmake/external/onnxruntime_external_deps.cmake: Language not supported
- onnxruntime/core/providers/webgpu/webgpu_context.cc: Language not supported
- onnxruntime/core/providers/webgpu/webgpu_context.h: Language not supported
- onnxruntime/core/providers/webgpu/webgpu_execution_provider.cc: Language not supported
- onnxruntime/core/providers/webgpu/webgpu_execution_provider.h: Language not supported
- onnxruntime/core/providers/webgpu/webgpu_provider_factory.cc: Language not supported
- onnxruntime/core/providers/webgpu/webgpu_provider_options.h: Language not supported
|
lint is not happy |
|
@guschmue Ok, I thought it was bots error when I see |
|
Turns out the lintrunner doesn't work correctly because it cannot find clang-format.exe(Maybe due to I have a depot_tools? The error message seems related). However, after I fixed it locally, the lintrunner works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PIX Capture tool requires 'present' to end a frame capture. ORT doesn't have rendering work so no 'present' happens.
To avoid endless waiting for PIX capture tool, this PR added a blank surface and 'present' on it in each session run.
The surface is created in WebGPU ep constructor and closed in WebGPU ep destructor.
Description
Motivation and Context