Allow pty.kill to be awaited

src/unixTerminal.ts

@@ -253,7 +253,7 @@ export class UnixTerminal extends Terminal {
     this._socket.destroy();
   }
 
-  public kill(signal?: string): void {
+  public async kill(signal?: string): Promise<void> {
     try {
       process.kill(this.pid, signal || 'SIGHUP');
     } catch (e) { /* swallow */ }

src/windowsPtyAgent.ts

@@ -157,21 +157,20 @@ export class WindowsPtyAgent {
     }
   }
 
-  public kill(): void {
+  public async kill(): Promise<void> {
     this._inSocket.readable = false;
     this._outSocket.readable = false;
     // Tell the agent to kill the pty, this releases handles to the process
     if (this._useConpty) {
-      this._getConsoleProcessList().then(consoleProcessList => {
-        consoleProcessList.forEach((pid: number) => {
-          try {
-            process.kill(pid);
-          } catch (e) {
-            // Ignore if process cannot be found (kill ESRCH error)
-          }
-        });
-        (this._ptyNative as IConptyNative).kill(this._pty, this._useConptyDll);
+      const consoleProcessList = await this._getConsoleProcessList();
+      consoleProcessList.forEach((pid: number) => {
+        try {
+          process.kill(pid);
+        } catch (e) {
+          // Ignore if process cannot be found (kill ESRCH error)
+        }
       });
+      (this._ptyNative as IConptyNative).kill(this._pty, this._useConptyDll);
     } else {
       // Because pty.kill closes the handle, it will kill most processes by itself.
       // Process IDs can be reused as soon as all handles to them are

src/windowsTerminal.ts

@@ -166,13 +166,16 @@ export class WindowsTerminal extends Terminal {
     });
   }
 
-  public kill(signal?: string): void {
-    this._deferNoArgs(() => {
-      if (signal) {
-        throw new Error('Signals not supported on windows.');
-      }
-      this._close();
-      this._agent.kill();
+  public kill(signal?: string): Promise<void> {
+    return new Promise((res, rej) => {
+      this._deferNoArgs(() => {
+        if (signal) {
+          rej(new Error('Signals not supported on windows.'));
+          return;
+        }
+        this._close();
+        this._agent.kill().then(res, rej);
+      });
     });
   }
 

typings/node-pty.d.ts

@@ -179,9 +179,9 @@ declare module 'node-pty' {
      * Kills the pty.
      * @param signal The signal to use, defaults to SIGHUP. This parameter is not supported on
      * Windows.
-     * @throws Will throw when signal is used on Windows.
+     * @throws Will reject when signal is used on Windows.
      */
-    kill(signal?: string): void;
+    kill(signal?: string): Promise<void>;
 
     /**
      * Pauses the pty for customizable flow control.