Introduced timeouts for MSAL calls. #2562
Open
+163
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machavan
requested review from
lilgreenbird,
tkyc,
David-Engel,
divang and
codewatchzen
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2562 +/- ##
============================================
+ Coverage 51.03% 51.14% +0.10%
- Complexity 3919 3927 +8
============================================
Files 147 147
Lines 33456 33478 +22
Branches 5604 5609 +5
============================================
+ Hits 17074 17122 +48
+ Misses 13971 13943 -28
- Partials 2411 2413 +2 ☔ View full report in Codecov by Sentry. |
src/test/java/com/microsoft/sqlserver/jdbc/SQLServerConnectionTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/microsoft/sqlserver/jdbc/SQLServerConnectionTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/microsoft/sqlserver/jdbc/SQLServerConnectionTest.java
Outdated
Show resolved
Hide resolved
Gueorgi
reviewed
Dec 16, 2024
Gueorgi
reviewed
Dec 16, 2024
- Added more tests - Improved test to check for specific error message
- Replaced lock with tryLock to avoid potential long waiting for other threads while one thread is taking long to complete.
001mertiya
reviewed
Dec 18, 2024
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerMSAL4JUtils.java
Outdated
Show resolved
Hide resolved
- Added detailed comment for the usage of semaphore.
lilgreenbird
reviewed
Jan 7, 2025
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerMSAL4JUtils.java
Outdated
Show resolved
Hide resolved
divang
reviewed
Jan 7, 2025
| try { | ||
| // | ||
| //Just try to acquire the semaphore and if can't then proceed to attempt to get the token. |
There was a problem hiding this comment.
Can we intergate mockito framework and simulate this scenario?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Calls to MSAL authentication library done from the Java driver code use future.get(), potentially leading to hangs in case the library does not receive timely response from the server. All these calls done as part of getFedAuthToken need to have timeouts imposed. The timeout period is calculated based on remaining time wrt login timeout, and passed to future.get(, ) calls with this fix.
Tests: