-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSON datatype support #2558
base: main
Are you sure you want to change the base?
JSON datatype support #2558
Conversation
@divang please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2558 +/- ##
============================================
- Coverage 51.01% 50.09% -0.93%
+ Complexity 3921 3829 -92
============================================
Files 147 147
Lines 33483 33544 +61
Branches 5609 5619 +10
============================================
- Hits 17081 16803 -278
- Misses 13991 14347 +356
+ Partials 2411 2394 -17 ☔ View full report in Codecov by Sentry. |
public void testJsonQuery() throws SQLException { | ||
try (Connection connection = getConnection(); Statement stmt = connection.createStatement()) { | ||
tableName = RandomUtil.getIdentifier("try_SQLJSON_Table"); | ||
TestUtils.dropTableIfExists(AbstractSQLGenerator.escapeIdentifier(tableName), stmt); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can consider enhancing this test to insert a couple of records, update the first record with a where predicate on JSON field itself, delete the second record (with a predicate), read the records back and validate that its 1 record with expected value of the json column.
/azp run public-mssql-jdbc.windows |
Azure Pipelines successfully started running 1 pipeline(s). |
No pipelines are associated with this pull request. |
/azp run public-mssql-jdbc.linux |
/azp run CI-MacOS |
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
Azure Pipelines successfully started running 1 pipeline(s). |
.escapeIdentifier(RandomUtil.getIdentifier("zeroParamSproc")); | ||
private static String tableNameJSON = "TestJSONTable"; | ||
private static String tableNameGUID = AbstractSQLGenerator | ||
.escapeIdentifier(RandomUtil.getIdentifier("uniqueidentifier_Table")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please maintain the current code formatting.
…m/microsoft/mssql-jdbc into user/divang/json-datatype-support
No description provided.