Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add publishing support for fedora 41 #4683

Closed
wants to merge 3 commits into from
Closed

Add publishing support for fedora 41 #4683

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dcfbf92
Add publishing support for fedora 41
sillyotter Dec 4, 2024
9628eea
Fixed destinations -> desination typo from earlier
sillyotter Dec 4, 2024
2f44042
Merge branch 'Publish-support-for-fedora-41' of github.com:sillyotter…
sillyotter Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .azure/OneBranch.Publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ parameters:
- name: RPM
destionations:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there is a typo here destionations -> destination?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is, it's been there for a while. Fedora 40 has been published, so i assumed what's there works. I didn't touch that line. Just duplicated the 40 line and tweaked it a bit to say 41.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the DEB section uses the same wording just a few lines away

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind fixing them?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR updated with the requested fix, though as before, I can't prove it works

- microsoft-fedora40-prod-yum # 40 6.8
- microsoft-fedora41-prod-yum # 41 6.11
- name: DEB
destinations:
- microsoft-ubuntu-noble-prod-apt # 24.04 6.8
Expand Down