Renaming channels #436
Open
Renaming channels #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
mahdiehghazim
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
I approved this PR. just have a few general comments/clarifying questions:
-
Based on the paper, the implementation of each channel is specific to the interconnect. For example, the PortChannel uses the DMA-copy data transfer mode over NVLink, xGMI, PCIe, and Infiniband." Does it mean we have different implementations for PortChannel to support each interconnect (NVLink, xGMI, PCIe, and Infiniband)? same question for MemoryChannel
-
Since this PR is changing many files, we need to make sure all mscclpp tests as well as nccl-tests/rccl-tests are passing before the merge
-
Once the paper is out, we can add a link to it in the repo
Binyang2014
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.