Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clang-cl compilation #982

Closed
wants to merge 1 commit into from
Closed

Conversation

MaxwellGengYF
Copy link

Fix this compile error on clang-cl compiler:

mimalloc\segment-map.c(131,61): error: unexpected type name 'mi_segmap_part_t': expected expression mi_segmap_part_t* part = mi_atomic_exchange_ptr_relaxed(mi_segmap_part_t, &mi_segment_map[i], NULL);

@MaxwellGengYF
Copy link
Author

@microsoft-github-policy-service agree

@daanx
Copy link
Collaborator

daanx commented Jan 6, 2025

Thank you for the PR! However, I think the various result casts are not needed. I tried to fix this in the latest commit to dev, 5764845 -- let me know if this works for you.

@MaxwellGengYF
Copy link
Author

It works, thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants