Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PersonPictureSettings API review #13

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
+81 −0
Open

PersonPictureSettings API review #13

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1d666a4
Review copy
Mar 1, 2019
60715fb
Merge branch 'master' into user/mikehillberg/PersonPictureReview
Mar 1, 2019
2927f07
Updates
Mar 1, 2019
9474c1c
Updates
Mar 1, 2019
e27e447
Updates
Mar 1, 2019
b05114b
review updates
jevansaks Mar 6, 2019
b022be1
Add back the sentence that was lost
jevansaks Mar 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
review updates
@jevansaks
jevansaks committed Mar 6, 2019
commit b05114b2968b72e78a8cdd4446d1086316d52482
12 changes: 6 additions & 6 deletions api_review/personpicture/PersonPictureAPI.md
View file
Original file line number Diff line number Diff line change
@@ -34,8 +34,8 @@ namespace Microsoft.UI.Xaml.Controls
[webhosthidden]
runtimeclass PersonPictureTemplateSettings : Windows.UI.Xaml.DependencyObject
{
String EffectiveInitials { get; };
Windows.UI.Xaml.Media.ImageBrush EffectiveImageBrush { get; };
String ActualInitials { get; };
Windows.UI.Xaml.Media.ImageBrush ActualImageBrush { get; };
}

}
@@ -57,13 +57,13 @@ This is intended for use in the style of the `PersonPicture` control. Sample usa
<!-- Visual State when a Photo is available for display -->
<VisualState x:Name="Photo">
<VisualState.Setters>
<Setter Target="PersonPictureEllipse.Fill" Value="{Binding RelativeSource={RelativeSource TemplatedParent}, Path=TemplateSettings.EffectiveImageBrush}"/>
<Setter Target="PersonPictureEllipse.Fill" Value="{Binding RelativeSource={RelativeSource TemplatedParent}, Path=TemplateSettings.ActualImageBrush}"/>
</VisualState.Setters>
</VisualState>
...
<TextBlock
...
Text="{Binding RelativeSource={RelativeSource TemplatedParent}, Path=TemplateSettings.EffectiveInitials}" />
Text="{Binding RelativeSource={RelativeSource TemplatedParent}, Path=TemplateSettings.ActualInitials}" />

```

@@ -77,5 +77,5 @@ This is intended for use in the style of the `PersonPicture` control. Sample usa
## Class: PersonPictureTemplateSettings
| Member Name | Description |
|:- |:--|
| EffectiveInitials | The initials that should be displayed in the control. Will be empty when image is specified or in group mode. |
| EffectiveImageBrush | The calculated image brush populated with the appropriate picture for the person. |
| ActualInitials | Empty when an image is specified or when the PersonPicture control represents a group. |
| ActualImageBrush | The image brush to use in the control. The PersonPicture control determines which image to use based on how it was configured. This property will be null when no image should be displayed. |