-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auth azure: support access token #3580
base: main
Are you sure you want to change the base?
Conversation
d5117f1
to
6e9a2fb
Compare
During testing, found this token is working for managing azure resources, I am consulting azure python sdk how to handle this. |
if "AZURE_ACCESS_TOKEN" in os.environ: | ||
credential = StaticAccessTokenCredential( | ||
os.environ["AZURE_ACCESS_TOKEN"], | ||
int(time.time()) + 3600 * azure_runbook.access_token_expiry_hours, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe try to parse the expiration time from the token itself. So, the parameter is not needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
What does it mean? Do you mean it fails in some scenarios, so you need have more tests or confirmation before merging? If so, please set it to Draft. |
6e9a2fb
to
be05158
Compare
be05158
to
f35f51f
Compare
Never mind, this one works. |
managed identity doesn't work with windows container directly for this reason
find a way to auth azure with access token