Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: support .kiota folder in ttk integration #5612

Merged
merged 9 commits into from
Nov 12, 2024

Conversation

thewahome
Copy link
Contributor

@thewahome thewahome commented Oct 16, 2024

Overview

Closes #5407

This PR changes the outputPath in workspace.json to .\appPackage so that the regeneration can happen in the appPackage folder inside the generated TTK plugin

Notes

TTK folder structure

Once the generation inside kiota is done, the {service}-apiplugin.json and {service}-openapi.yml files are sent over to ttk, renamed and separated to fit in the folder structure below

[Figure 1]

appPackage/
├── apiSpecificationFile/
│   └── openapi.yaml
├── ...
└── ai-plugin.json

To support regeneration through this path, the .kiota folder from kiota would need to be handed over to ttk too, changing the structure to

[Figure 2]

.kiota /
  ├── documents/
  ├── workspace.json
  └── manifest.json
appPackage/
├── apiSpecificationFile/
│   └── openapi.yaml
├── ...
├── manifest.json
└── ai-plugin.json

This new structure would help with regeneration.

Findings

  • Placing the new .kiota folder inside the ttk plugin with the above structure allows for regeneration of the plugin successfully.
  • There would need to be a step handled by TTK that renames the files re-generated ({service}-apiplugin.json and {service}-openapi.yml) to suit the naming defined in [Figure 1]

@thewahome thewahome requested a review from a team as a code owner October 16, 2024 11:37
@thewahome thewahome marked this pull request as draft October 16, 2024 11:37
@thewahome thewahome marked this pull request as ready for review November 5, 2024 12:30
@thewahome thewahome requested a review from calebkiage November 11, 2024 10:25
Copy link

Quality Gate Failed Quality Gate failed for 'kiota'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@thewahome thewahome merged commit 25a3952 into main Nov 12, 2024
211 of 212 checks passed
@thewahome thewahome deleted the task/extension/support-kiota-folder-ttk branch November 12, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

TTK and Kiota integrated flow should support regeneration of plugins
3 participants