Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing array of primitive types in union or intersection types #5348

Merged
merged 4 commits into from
Sep 6, 2024
Merged

fix: missing array of primitive types in union or intersection types #5348

merged 4 commits into from
Sep 6, 2024

Conversation

baywet
Copy link
Member

@baywet baywet commented Sep 5, 2024 •
edited
Loading

fixes #5283

@baywet baywet requested a review from a team as a code owner September 5, 2024 19:48
@baywet baywet self-assigned this Sep 5, 2024
@baywet baywet enabled auto-merge September 5, 2024 19:48
@baywet baywet mentioned this pull request Sep 5, 2024
Closed
andrueastman
andrueastman previously approved these changes Sep 6, 2024
View reviewed changes
@andrueastman andrueastman dismissed their stale review September 6, 2024 06:34

TS and PHP intergration tests failing for stripe api.

@baywet baywet mentioned this pull request Sep 6, 2024
Closed
@baywet
Copy link
Member Author

baywet commented Sep 6, 2024

@andrueastman I just pushed an additional commit so the typescript generation doesn't blow up anymore.
But it won't build either, so I created this issue for the team to follow up on.
#5353

andrueastman
andrueastman previously approved these changes Sep 6, 2024
View reviewed changes
@baywet baywet mentioned this pull request Sep 6, 2024
Open
@baywet
Copy link
Member Author

baywet commented Sep 6, 2024

Also #5354

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Sep 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@baywet baywet merged commit bb00862 into main Sep 6, 2024
209 checks passed
@baywet baywet deleted the fix/array-union branch September 6, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrueastman andrueastman andrueastman approved these changes

Assignees

@baywet baywet

Labels
None yet
Projects
Kiota
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

String arrays under OneOf do not produce the expected generated result
2 participants
@baywet @andrueastman