Fix CRC16 perf regression on .NET 6 #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Non-byte sized RVA statics are only supported from .NET 7 onwards.
PaulusParssinen
changed the title
TedHartMS
approved these changes
Apr 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #198 I switched the CRC16 table to use RVA statics which as implementation detail places the constant data table to
.datasection (and does endianness fix-ups for big-endian platforms). However the support non-byte sized primitives in RVA only is supported from .NET 7 onwards which made current code allocate this table on each getter call.. Oops.This PR restores performance characteristics of the original implementation for .NET 6.