Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add COMMAND COUNT #188

Closed
wants to merge 2 commits into from
Closed

add COMMAND COUNT #188

wants to merge 2 commits into from

Conversation

tisilent
Copy link
Contributor

@TalZaccai TalZaccai self-requested a review March 29, 2024 18:25
@TalZaccai
Copy link
Contributor

Thank you for your contribution! Unfortunately this does not currently return the correct response and can be confusing as there are commands missing from RespInfo that will not be counted (e.g. CLUSTER commands, custom commands etc.).
We will address this missing COUNT command when we implement the actual COMMAND command itself first (in the works).
Closing this for now, but we might use some of it when we do implement COMMAND COUNT...
Thanks again & much appreciated!

@TalZaccai TalZaccai closed this Apr 1, 2024
@tisilent tisilent deleted the add-command-count branch April 3, 2024 01:01
@github-actions github-actions bot locked and limited conversation to collaborators Jun 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TalZaccai TalZaccai Awaiting requested review from TalZaccai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tisilent @TalZaccai