Seal more Tsavorite internals (#341)

* Good type hygiene & potential minor perf. benefits Co-authored-by: Ted Hart <[email protected]>
microsoft · Apr 29, 2024 · 8cf25f6 · 8cf25f6
1 parent 023f1fe
commit 8cf25f6
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 6 deletions.
diff --git a/libs/storage/Tsavorite/cs/src/core/Allocator/ErrorList.cs b/libs/storage/Tsavorite/cs/src/core/Allocator/ErrorList.cs
@@ -5,7 +5,7 @@
 
 namespace Tsavorite.core
 {
-    class ErrorList
+    internal sealed class ErrorList
     {
         private List<CommitInfo> errorList;
 

diff --git a/libs/storage/Tsavorite/cs/src/core/Allocator/MemoryPageScanIterator.cs b/libs/storage/Tsavorite/cs/src/core/Allocator/MemoryPageScanIterator.cs
@@ -11,7 +11,7 @@ namespace Tsavorite.core
     /// </summary>
     /// <typeparam name="Key"></typeparam>
     /// <typeparam name="Value"></typeparam>
-    class MemoryPageScanIterator<Key, Value> : ITsavoriteScanIterator<Key, Value>
+    internal sealed class MemoryPageScanIterator<Key, Value> : ITsavoriteScanIterator<Key, Value>
     {
         readonly Record<Key, Value>[] page;
         readonly long pageStartAddress;

diff --git a/libs/storage/Tsavorite/cs/src/core/Allocator/PendingFlushList.cs b/libs/storage/Tsavorite/cs/src/core/Allocator/PendingFlushList.cs
@@ -5,7 +5,7 @@
 
 namespace Tsavorite.core
 {
-    sealed class PendingFlushList
+    internal sealed class PendingFlushList
     {
         public readonly LinkedList<PageAsyncFlushResult<Empty>> list;
 

diff --git a/libs/storage/Tsavorite/cs/src/core/Allocator/WorkQueueFIFO.cs b/libs/storage/Tsavorite/cs/src/core/Allocator/WorkQueueFIFO.cs
@@ -12,7 +12,7 @@ namespace Tsavorite.core
     /// Shared work queue that ensures one worker at any given time. Uses FIFO ordering of work.
     /// </summary>
     /// <typeparam name="T"></typeparam>
-    class WorkQueueFIFO<T> : IDisposable
+    internal sealed class WorkQueueFIFO<T> : IDisposable
     {
         const int kMaxQueueSize = 1 << 30;
         readonly ConcurrentQueue<T> _queue;

diff --git a/libs/storage/Tsavorite/cs/src/core/Allocator/WorkQueueLIFO.cs b/libs/storage/Tsavorite/cs/src/core/Allocator/WorkQueueLIFO.cs
@@ -12,7 +12,7 @@ namespace Tsavorite.core
     /// Shared work queue that ensures one worker at any given time. Uses LIFO ordering of work.
     /// </summary>
     /// <typeparam name="T"></typeparam>
-    class WorkQueueLIFO<T> : IDisposable
+    internal sealed class WorkQueueLIFO<T> : IDisposable
     {
         const int kMaxQueueSize = 1 << 30;
         readonly ConcurrentStack<T> _queue;

diff --git a/libs/storage/Tsavorite/cs/src/core/Device/AsyncPool.cs b/libs/storage/Tsavorite/cs/src/core/Device/AsyncPool.cs
@@ -13,7 +13,7 @@ namespace Tsavorite.core
     /// Supports sync get (TryGet) for fast path
     /// </summary>
     /// <typeparam name="T"></typeparam>
-    public class AsyncPool<T> : IDisposable where T : IDisposable
+    internal sealed class AsyncPool<T> : IDisposable where T : IDisposable
     {
         readonly int size;
         readonly Func<T> creator;