-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Advisor and Resource Graph recommendations exports to Hubs #1130
Open
helderpinto
wants to merge
20
commits into
microsoft:features/recs
Choose a base branch
from
helderpinto:helderpinto/dev/recommendationsexport
base: features/recs
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Adding Advisor and Resource Graph recommendations exports to Hubs #1130
helderpinto
wants to merge
20
commits into
microsoft:features/recs
from
helderpinto:helderpinto/dev/recommendationsexport
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
requested review from
arthurclares and
flanakin
November 16, 2024 12:07
microsoft-github-policy-service
bot
added
the
Needs: Review 👀
PR that is ready to be reviewed
label
Nov 16, 2024
flanakin
requested changes
Dec 19, 2024
microsoft-github-policy-service
bot
added
Needs: Attention 👋
Issue or PR needs to be reviewed by the author or it will be closed due to no activity
and removed
Needs: Review 👀
PR that is ready to be reviewed
labels
Dec 19, 2024
Co-authored-by: Michael Flanakin <[email protected]>
microsoft-github-policy-service
bot
added
Needs: Review 👀
PR that is ready to be reviewed
and removed
Needs: Attention 👋
Issue or PR needs to be reviewed by the author or it will be closed due to no activity
labels
Dec 20, 2024
…b.com/helderpinto/finops-toolkit into helderpinto/dev/recommendationsexport
Co-authored-by: Michael Flanakin <[email protected]>
…b.com/helderpinto/finops-toolkit into helderpinto/dev/recommendationsexport
@flanakin, the ADF pipeline was refactored to become query type-agnostic. It is now prepared to deal with other query types in the future. There are still some unresolved conversations. Feel free to ping me offline or let's set up a meeting to discuss this further. |
microsoft-github-policy-service
bot
requested review from
ro100e and
RolandKrummenacher
January 5, 2025 21:13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Description
This is the first PR in a series of PRs that will add Advisor and Resource Graph recommendations exports to Hubs. This PR includes the initial Advisor/ARG recommendations export and the schema for recommendations. It is compatible with Data Explorer ingestion. For this PR, we also fixed Western Europe timezones.
The upcoming PRs will address documentation, reporting, and granting permissions to the ADF identity at a higher scope, for the recommendations exports to succeed. Currently, Reader permissions have to be granted manually at the subscription or management group level.
📋 Checklist
🔬 How did you test this change?
🙋♀️ Do any of the following that apply?
📑 Did you update
docs/changelog.md
?📖 Did you update documentation?