Allow relative paths in the 'remotePath' for a launch.json #1803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamYoblick
reviewed
Jan 9, 2025
| @@ -747,6 +753,16 @@ def setup_client_server_paths(paths): | |||
| initial_paths_with_end_sep.append((path0, path1)) | |||
| paths_from_eclipse_to_python_with_end_sep.append((_normcase_from_client(path0), normcase(path1))) | |||
|
|
|||
| if DEBUG_CLIENT_SERVER_TRANSLATION: | |||
| pydev_log.critical( | |||
AdamYoblick
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #1301
Users in issue 1301 were attempting to do something like so:
In pydevd this isn't supported. The remote and local roots have to be fully specified. This is a pain in a shared situation though as you can pass environment variables for the local path but not the remote.
This change allows the user to have a relative (to the current working directory) for the remote path.