Fix multithreading stepping in 3.12 and later #1798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamYoblick
reviewed
Jan 7, 2025
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
Is this file supposed to be in source control? It might be, I just wasn't sure since it was in the .vscode directory
There was a problem hiding this comment.
It can be. It's common settings. It makes debugpy tests runnable from the test runner in VS code.
AdamYoblick
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1765
After adding a bunch of logging I found that one thread would send a breakpoint event, 'return' events were still being fired for other threads. When the 'breakpoint' thread suspended itself and all other threads, it sets the 'step' mode for all other threads to step into, so when those return events came in, we were getting other threads in step mode. This makes the debugger jump all over the place when stepping (as all threads look like they're stepping).
The fix here was to just ignore any events after a thread is suspended. Other threads shouldn't be sending a separate stopped event after they've been suspended.
Added a test to pydevd to verify this works.