Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dotnet releases index url #20748

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

Varorbc
Copy link

@Varorbc Varorbc commented Dec 23, 2024

Task name: DotNetCoreInstaller、UseDotNet

Description: Update dotnet releases index url

Documentation changes required: N

Added unit tests: N

Attached related issue: N

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@JamieMagee
Copy link
Member

Related: dotnet/core#9671

@Varorbc
Copy link
Author

Varorbc commented Dec 24, 2024

@merlynomsft @tarunramsinghani @DergachevE Can you help take a look? And give me some advice, this issue has been bothering me for a long time, I hope it can be merged as soon as possible.

@DergachevE
Copy link
Contributor

@Varorbc thanks for your contribution.
We have already this PR 20752 merged to updated releases URLs.

Also as I can see that you didn't bump the task version

@Varorbc
Copy link
Author

Varorbc commented Dec 25, 2024

@DergachevE That pull request only updated the download url, not the index url. Also, could you let me know which version number I should update to?

@Varorbc
Copy link
Author

Varorbc commented Dec 25, 2024

@DergachevE I've bumped the task version. Could you take another look?

Copy link
Collaborator

@tarunramsinghani tarunramsinghani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Merging.

@tarunramsinghani tarunramsinghani requested a review from a team as a code owner January 3, 2025 06:45
@microsoft microsoft deleted a comment from azure-pipelines bot Jan 3, 2025
@Varorbc
Copy link
Author

Varorbc commented Jan 4, 2025

@tarunramsinghani Can't pull requests be merged yet? What else do I need to do?

@tarunramsinghani tarunramsinghani enabled auto-merge (squash) January 8, 2025 09:45
@microsoft microsoft deleted a comment from azure-pipelines bot Jan 8, 2025
@tarunramsinghani
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@tarunramsinghani
Copy link
Collaborator

@Varorbc, can you please raise a PR from this repo instead of forked repo to make sure the checks are run before merging.

@Varorbc
Copy link
Author

Varorbc commented Jan 8, 2025

I'm really puzzled about why I need to create a branch in this repository. Do I even have the permissions to create a branch here? Isn't the usual process for creating a pull request to first fork the repository, then create and work on a branch in my own fork before submitting changes?

@Varorbc
Copy link
Author

Varorbc commented Jan 8, 2025

@tarunramsinghani Could you tell me how to do it step by step?

@Varorbc
Copy link
Author

Varorbc commented Jan 8, 2025

/azp run

Copy link

Commenter does not have sufficient privileges for PR 20748 in repo microsoft/azure-pipelines-tasks

@tarunramsinghani
Copy link
Collaborator

@Varorbc I'll get back with instructions soon.

@tarunramsinghani
Copy link
Collaborator

Meanwhile, I can cherrypick these changes and raise a PR to make sure that changes are merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants