Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add documentation for testing docs related changes #58

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

romoh
Copy link
Contributor

@romoh romoh commented Dec 30, 2024


Checklist

  • Tests added/updated
  • Documentation updated (if needed)
  • Code conforms to style guidelines

Signed-off-by: Roaa Sakr <[email protected]>
@romoh romoh requested a review from a team as a code owner December 30, 2024 19:19
docs/README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
Signed-off-by: Roaa Sakr <[email protected]>
Signed-off-by: Roaa Sakr <[email protected]>
@romoh romoh requested a review from amritakohli December 30, 2024 21:36
@@ -0,0 +1,47 @@
# Testing github pages locally
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: # Testing GitHub Pages Locally with Jekyll


* Install dependencies

```bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tab in (2 spaces). Otherwise, you are breaking the list.


```bash
cat <<EOF > Gemfile
source "https://rubygems.org"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason you aren’t including this file in the repo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't want it to interfere with what the github workflow autogenerates.
My guess is we get version upgrades.. etc for free with the workflow and would be good to keep it as is.

bundle install
```

* Update `_config.yml`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Jekyll command line allows you to specify multiple config files, with later config files overriding values of earlier config files. Could this be used to avoid needing to temporarily modify the _config.yml file?


* Install dependencies

```bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specify the distro+version this is applicable to. Also, if these tools are available in Azure Linux, it would be to provide steps for that as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants