Skip to content

Commit

Permalink
more
Browse files Browse the repository at this point in the history
Signed-off-by: Roaa Sakr <[email protected]>
  • Loading branch information
romoh committed Jan 2, 2025
1 parent 75dde11 commit 546983a
Showing 1 changed file with 14 additions and 14 deletions.
28 changes: 14 additions & 14 deletions toolkit/tools/pkg/imagecustomizerlib/runscripts_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -67,24 +67,24 @@ resolv.conf exists
verifyFileContentsSame(t, aOrigFilePath, aNewFilePath)
}

func TestCustomizeImageRunScriptsIptables(t *testing.T) {
var err error
// // Disabled due to regression in functionality - Tracked by a bug
// func TestCustomizeImageRunScriptsIptables(t *testing.T) {
// var err error

baseImage := checkSkipForCustomizeImage(t, baseImageTypeCoreEfi, baseImageVersionDefault)
// baseImage := checkSkipForCustomizeImage(t, baseImageTypeCoreEfi, baseImageVersionDefault)

testTmpDir := filepath.Join(tmpDir, "TestCustomizeImageRunScriptsIptables")
buildDir := filepath.Join(testTmpDir, "build")
configFile := filepath.Join(testDir, "runscripts-iptables.yaml")
outImageFilePath := filepath.Join(testTmpDir, "image.raw")
// testTmpDir := filepath.Join(tmpDir, "TestCustomizeImageRunScriptsIptables")
// buildDir := filepath.Join(testTmpDir, "build")
// configFile := filepath.Join(testDir, "runscripts-iptables.yaml")
// outImageFilePath := filepath.Join(testTmpDir, "image.raw")

// Customize image.
err = CustomizeImageWithConfigFile(buildDir, configFile, baseImage, nil, outImageFilePath, "raw", "",
"" /*outputPXEArtifactsDir*/, false /*useBaseImageRpmRepos*/, false /*enableShrinkFilesystems*/)
assert.ErrorContains(t, err, "failed to customize raw image")
assert.ErrorContains(t, err, "script (postCustomization[0]) failed")
}
// // Customize image.
// err = CustomizeImageWithConfigFile(buildDir, configFile, baseImage, nil, outImageFilePath, "raw", "",
// "" /*outputPXEArtifactsDir*/, false /*useBaseImageRpmRepos*/, false /*enableShrinkFilesystems*/)
// assert.ErrorContains(t, err, "failed to customize raw image")
// assert.ErrorContains(t, err, "script (postCustomization[0]) failed")
// }

// Disabled due to regression in functionality - Tracked by a bug
// func TestCustomizeImageRunScriptsModprobe(t *testing.T) {
// var err error

Expand Down

0 comments on commit 546983a

Please sign in to comment.