Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make the search box border consistent in all themes #1760

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

DaveTryon
Copy link
Contributor

Details

As called out in #1758, the search box doesn't meet non-text color contrast requirements. This PR changes the border so that it's consistently displayed in all themes.

Motivation

Address #1758

Screenshots
Mode Before (only dark mode has border) After (all modes have border)
Light image image
Dark image image
Aquatic image image
Desert image image
Dusk image image
Night Sky image image
Context

Since the SearchPanelBorderThickness value is now always 1, I replaced the variable (originally added for dark mode) with a hardcoded value

Pull request checklist

  • Run through of all test scenarios completed?
  • Does this address an existing issue? If yes, Issue# - 1758
  • Includes UI changes?
    • Run the production version of Accessibility Insights for Windows against a version with changes.
    • Attach any screenshots / GIF's that are applicable.

Note: After the PR has been created, certain checks will be kicked off. All of these checks must pass before a merge.

@DaveTryon DaveTryon requested a review from a team as a code owner January 17, 2024 20:55
Copy link

@peterdur peterdur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and verified behavior before and after change with default and HC themes

@DaveTryon DaveTryon merged commit 449e227 into microsoft:main Jan 19, 2024
7 checks passed
@DaveTryon DaveTryon deleted the consistent-border-on-search-box branch January 25, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants