refactor: remove obsolete persistStoreData flag from PersistentStore #6300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, turns out this is still used for unified, oops |
3 tasks
|
PR taken over at #6864. |
codeofdusk
added a commit
that referenced
this pull request
Aug 4, 2023
… take 2 (#6864) When we originally introduced `PersistentStore` during the MV2->MV3 transition, it included a `persistStoreData` constructor flag which allowed us to gradually transition different stores to using persistence depending on whether we were working with an MV2 or MV3 build. This functionality is now obsolete - all `PersistentStore`-based stores always use this with a constant `true` input. This commit removes the obsolete flag. This is a takeover of abandoned #6300, which was closed due to the flag's usage in Unified. Now that Unified is gone, this change is unblocked. Noticed while working on #6233 Co-authored-by: Dan Bjorge <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
When we originally introduced
PersistentStoreduring the MV2->MV3 transition, it included apersistStoreDataconstructor flag which allowed us to gradually transition different stores to using persistence depending on whether we were working with an MV2 or MV3 build. This functionality is now obsolete - allPersistentStore-based stores always use this with a constanttrueinput. This PR removes the obsolete flag.This refactor is fairly simple but touches a lot of files, so I wanted to give it its own PR for ease of review.
Motivation
Clean up obsolete code
Context
Noticed while working on #6233
Pull request checklist
yarn fastpassyarn test)<rootDir>/test-results/unit/coveragefix:,chore:,feat(feature-name):,refactor:). SeeCONTRIBUTING.md.