chore(null): strict null fixes for dialog-renderer deps #6223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
dbjorge
added a commit
that referenced
this pull request
Dec 5, 2022
…#6234) #### Details This PR continues from #6223 and fixes another few layers of `injected/visualization` files to be strict null check compatible. It substantially refactors `accessibile-name-formatter` and somewhat refactors `landmark-formatter` - I manually smoke tested those ad hoc tools to verify that they still worked after the changes ##### Motivation #2869 ##### Context n/a #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [x] Addresses an existing issue: #2869 - [x] Ran `yarn null:autoadd` - [x] Ran `yarn fastpass` - [x] Added/updated relevant unit test(s) (and ran `yarn test`) - [x] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage` - [x] PR title *AND* final merge commit title both start with a semantic tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See `CONTRIBUTING.md`. - [n/a] (UI changes only) Added screenshots/GIFs to description above - [n/a] (UI changes only) Verified usability with NVDA/JAWS
6 tasks
dbjorge
added a commit
that referenced
this pull request
Dec 6, 2022
…, deps (#6244) #### Details This PR continues the work from #6226 and #6223, adding another layer of injected files to the strict null check list. The only case with a notable behavioral change is that axe-core technically documents in its typings that it's allowed to omit a "how to fix" section from results, but if it were to actually do so, our cards UI would currently crash. I don't think axe-core actually omits that info in practice (I suspect it's there to accomodate custom rules), but now if it were to do so, we'd omit the section from the card rather than crashing (similar to how we handle results with missing snippets). This ended up enabling a *lot* of files to be autoadded! It brings us from ~72% null-strict to ~78% ```markdown ## Web strict-null progress **78%** complete (**1210**/1561 non-test files) *Contribute at [#2869](#2869). Last update: Mon Dec 05 2022* Done in 1.00s. ``` ##### Motivation #2869 ##### Context n/a #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [x] Addresses an existing issue: #2869 - [x] Ran `yarn null:autoadd` - [x] Ran `yarn fastpass` - [x] Added/updated relevant unit test(s) (and ran `yarn test`) - [x] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage` - [x] PR title *AND* final merge commit title both start with a semantic tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See `CONTRIBUTING.md`. - [n/a] (UI changes only) Added screenshots/GIFs to description above - [n/a] (UI changes only) Verified usability with NVDA/JAWS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR adds a bunch of
injected/visualizationfiles to the strictNullCheck set. To do this, I introduced an interface seam forDialogRenderer(since it has dependencies on lots of non-null-clean components) and then did two rounds ofyarn null:find/yarn null:autoadd.I also included a few fixes for dialog-renderer-impl that I started making before deciding to introduce the interface seam. It is intentionally omitted from the strictNullChecks config since it still has non-clean dependencies.
Motivation
See #2869
Context
n/a
Pull request checklist
yarn null:autoaddyarn fastpassyarn test)<rootDir>/test-results/unit/coveragefix:,chore:,feat(feature-name):,refactor:). SeeCONTRIBUTING.md.