chore(null): strict null check fixes #5457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 17 commits
May 2, 2022 10:47
…ights-web into null-checks-larger-changes
madalynrose
commented
May 5, 2022
| @@ -39,7 +39,7 @@ export class FailedInstancePanel extends React.Component<FailedInstancePanelProp | |||
| label="Comment" | |||
| multiline={true} | |||
| rows={8} | |||
| value={this.props.instanceDescription} | |||
| value={this.props.instanceDescription ?? ''} | |||
There was a problem hiding this comment.
The TextField component expects a string.
madalynrose
commented
May 5, 2022
| @@ -47,8 +47,8 @@ export const TabStopsFailedInstancePanel = NamedFC<TabStopsFailedInstancePanelPr | |||
| confirmButtonText: 'Add failed instance', | |||
| onConfirm: () => { | |||
| tabStopRequirementActionMessageCreator.addTabStopInstance({ | |||
| description: failureInstanceState.description, | |||
| requirementId: failureInstanceState.selectedRequirementId, | |||
| description: failureInstanceState.description!, | |||
There was a problem hiding this comment.
This is only called when the form is submitted, and the form can only be submitted once values for these attributes are provided.
madalynrose
commented
May 5, 2022
| @@ -73,8 +73,8 @@ export class ScanController { | |||
| const payload = this.unifiedResultsBuilder(data); | |||
|
|
|||
| this.unifiedScanResultAction.scanCompleted.invoke(payload); | |||
| this.scanActions.scanCompleted.invoke(null); | |||
| this.deviceConnectionActions.statusConnected.invoke(null); | |||
| this.scanActions.scanCompleted.invoke(); | |||
There was a problem hiding this comment.
passing null vs void does not alter the behavior of the invocation so we should call the function without params as intended
madalynrose
commented
May 5, 2022
| @@ -125,7 +125,7 @@ export class ConvertScanResultsToUnifiedResults { | |||
| snippet: nodeResult.snippet || nodeResult.html, | |||
| }, | |||
| resolution: { | |||
| howToFixSummary: nodeResult.failureSummary, | |||
| howToFixSummary: nodeResult.failureSummary!, | |||
There was a problem hiding this comment.
The way we have architected our Unified Results ensures that every rule has an associated failureSummary.
madalynrose
commented
May 5, 2022
| @@ -60,7 +60,7 @@ export class FocusChangeHandler { | |||
| } | |||
|
|
|||
| private findAutomatedChecksFocusedResult(storeData: TargetPageStoreData): UnifiedResult { | |||
| const focusedResult = storeData.unifiedScanResultStoreData.results.find( | |||
| const focusedResult = storeData.unifiedScanResultStoreData.results!.find( | |||
There was a problem hiding this comment.
These functions are only called once we have results.
peterdur
approved these changes
May 16, 2022
peterdur
reviewed
May 16, 2022
| screenshotData?: ScreenshotData; | ||
| results: UnifiedResult[] | null; | ||
| rules: UnifiedRule[] | null; | ||
| platformInfo?: PlatformData | null; |
There was a problem hiding this comment.
It reads a little strange to have thing?: Type | null but I still like ? for optional fields...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR took all the
yarn null:findresults that were resolvable with some extra digging (verifying values will not be falsy when passed into functions, mostly), added them totsconfig.strictNullChecks.json, fixed the resulting errors, and cleaned up withyarn null:autoaddafter.yarn null:progressbefore: 66% complete (995/1515 non-test files)yarn null:progressafter: 66% complete (1002/1516 non-test files)Motivation
#2869
Context
Adding inline comments to this PR where context is needed.
Pull request checklist
yarn fastpassyarn test)<rootDir>/test-results/unit/coveragefix:,chore:,feat(feature-name):,refactor:). SeeCONTRIBUTING.md.