Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(null): small strict null fixes #5449

Merged
merged 8 commits into from
May 3, 2022

Conversation

madalynrose
Copy link
Contributor

Details

This PR took all the yarn null:find results that only had a small number of errors per file, added them to tsconfig.strictNullChecks.json, fixed the resulting errors, and cleaned up with yarn null:autoadd after.

yarn:null:progress before: 64% complete (963/1515 non-test files)
yarn:null:progress after: 66% complete (995/1515 non-test files)

Motivation

#2869

Pull request checklist

  • Addresses an existing issue: Codebase should use strict null checks #2869
  • Ran yarn fastpass
  • Added/updated relevant unit test(s) (and ran yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.

@madalynrose madalynrose requested a review from a team as a code owner May 2, 2022 19:02
@madalynrose madalynrose merged commit 3be0542 into microsoft:main May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants