Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(null): inspect and card selection store + auto add others #4751

Merged
merged 3 commits into from
Sep 29, 2021
Merged

chore(null): inspect and card selection store + auto add others #4751

merged 3 commits into from
Sep 29, 2021

Conversation

waabid
Copy link
Member

@waabid waabid commented Sep 29, 2021

Details

Auto-adding a few files + manually adding inspect store and card selection store.

Motivation

#2869

Context

Pull request checklist

  • Addresses an existing issue: Codebase should use strict null checks #2869
  • Ran yarn fastpass
  • [.] Added/updated relevant unit test(s) (and ran yarn test)
  • [.] Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • (UI changes only) Added screenshots/GIFs to description above
  • (UI changes only) Verified usability with NVDA/JAWS

@waabid waabid requested a review from a team as a code owner September 29, 2021 23:11
@waabid waabid merged commit 8d74a98 into microsoft:main Sep 29, 2021
@waabid waabid deleted the strictNullChecks0929 branch January 27, 2022 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbjorge dbjorge dbjorge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@waabid @dbjorge