chore(null): null strictness fixes for 9/15's top 10 null:find results #3359
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Another round of the top ten
yarn null:find
results, plus the extra dependent files thatyarn null:autoadd
revealed were fixed as a side effect of the first fixes.The most interesting/notable change here is in the error handling improvements to
target-tab-finder.ts
; previously, a few edge cases the browser could return to us would result in a string error or a "cannot reference property url of undefined" error, where now they will throw more meaningfulError
objects. Tests were updated to accomodate.Before:
After:
Pull request checklist
yarn fastpass
yarn test
)<rootDir>/test-results/unit/coverage
fix:
,chore:
,feat(feature-name):
,refactor:
). SeeCONTRIBUTING.md
.