Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(null): fix yarn null:find on windows #3340

Merged
merged 5 commits into from
Sep 11, 2020

Conversation

dbjorge
Copy link
Contributor

@dbjorge dbjorge commented Sep 11, 2020

Description of changes

The primary impact/motivation here was to fix an issue where yarn null:find wasn't outputting all the files it was supposed to (as it turns out, this was windows-specific). The fix for this is on line 39 of import-finder.js (different parts of the tool weren't in agreement about normalizing slashes, which was breaking some of the filtering logic).

As part of fixing/debugging this, I did a fair amount of refactoring/cleanup to null:find. I didn't separate out the cleanup into a separate PR like I normally would because this is a short-lived dev-only tool that doesn't require as thorough review as most of the repo's code.

Pull request checklist

  • Addresses an existing issue: related to Codebase should use strict null checks #2869
  • Ran yarn fastpass
  • [n/a] Added/updated relevant unit test(s) (and ran yarn test)
  • [n/a] Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • [n/a] (UI changes only) Added screenshots/GIFs to description above
  • [n/a] (UI changes only) Verified usability with NVDA/JAWS

@dbjorge dbjorge requested a review from a team as a code owner September 11, 2020 00:41
@dbjorge dbjorge merged commit 559b6a5 into microsoft:master Sep 11, 2020
@dbjorge dbjorge deleted the null-find-fix branch September 11, 2020 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants