Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(null): make yarn null:autoadd sort and collapse added cases by directory #3329

Merged
merged 1 commit into from
Sep 10, 2020

Conversation

dbjorge
Copy link
Contributor

@dbjorge dbjorge commented Sep 8, 2020

Description of changes

This PR improves the readability of yarn null:autoadd output by making it automatically collapse cases where an entire directory is detected as "completed" into a directory-wise include pattern, rather than listing out individual files.

Pull request checklist

  • Addresses an existing issue: part of Codebase should use strict null checks #2869
  • Ran yarn fastpass
  • [n/a] Added/updated relevant unit test(s) (and ran yarn test)
  • [n/a] Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • [n/a] (UI changes only) Added screenshots/GIFs to description above
  • [n/a] (UI changes only) Verified usability with NVDA/JAWS

@dbjorge dbjorge requested a review from a team as a code owner September 8, 2020 22:16
@dbjorge dbjorge merged commit 10ff226 into microsoft:master Sep 10, 2020
@dbjorge dbjorge deleted the null-fixes-0908 branch September 10, 2020 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants