Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(null): null-correctness for test utils #3035

Merged
merged 1 commit into from
Jul 7, 2020
Merged

chore(null): null-correctness for test utils #3035

merged 1 commit into from
Jul 7, 2020

Conversation

dbjorge
Copy link
Contributor

@dbjorge dbjorge commented Jul 7, 2020 •
edited
Loading

Description of changes

Adds test utility files noted by yarn null:find to strict-null set.

Pull request checklist

  • Addresses an existing issue: Codebase should use strict null checks #2869
  • Ran yarn fastpass
  • Added/updated relevant unit test(s) (and ran yarn test)
  • [n/a] Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • [n/a] (UI changes only) Added screenshots/GIFs to description above
  • [n/a] (UI changes only) Verified usability with NVDA/JAWS

@dbjorge dbjorge marked this pull request as ready for review July 7, 2020 00:41
@dbjorge dbjorge requested a review from a team as a code owner July 7, 2020 00:41
@dbjorge dbjorge merged commit 675ae80 into microsoft:master Jul 7, 2020
@dbjorge dbjorge deleted the null-3 branch July 7, 2020 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterdur peterdur peterdur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbjorge @peterdur