Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(strict-null): add strict null check migration tools to repo #2957

Merged
merged 9 commits into from
Jun 29, 2020

Conversation

dbjorge
Copy link
Contributor

@dbjorge dbjorge commented Jun 24, 2020

Description of changes

This integrates the strict null checking tools that I migrated from VS Code's as an experiment in https://github.com/dbjorge/aiweb-strict-null-check-migration-tools into the /tools/ folder of our repo, to make it easier for others to use them.

As part of the migration, I eliminated the separate package.json machinery for the tools and had them just re-use the same node_modules as the main project (in particular, re-using the correct typescript version). I also added entry point run-scripts for the tools to our root-level package.json, so the source for the tools should be an implementation detail for most purposes of actually running null check migration work; usage is just yarn null:find and yarn null:autoadd from the root, to match the previously-added yarn null:check.

I've updated #2869 with instructions for how to use these scripts to contribute to the strict null check migration work.

Pull request checklist

  • Addresses an existing issue: tools to help address Codebase should use strict null checks #2869
  • Ran yarn fastpass
  • [n/a] Added/updated relevant unit test(s) (and ran yarn test)
  • [n/a] Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • [n/a] (UI changes only) Added screenshots/GIFs to description above
  • [n/a] (UI changes only) Verified usability with NVDA/JAWS

@dbjorge dbjorge requested a review from a team as a code owner June 24, 2020 21:01
Copy link
Contributor

@karanbirsingh karanbirsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question comment

@dbjorge dbjorge merged commit 74792d3 into microsoft:master Jun 29, 2020
@dbjorge dbjorge deleted the strict-null-tools branch June 29, 2020 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants