Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Resolved issue in pipeline validation for CreateReleaseTag #2248

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

v-sharmachir
Copy link
Contributor

@v-sharmachir v-sharmachir commented Dec 17, 2024

Details

Resolved issue in pipeline validation for CreateReleaseTag.

Pipeline was failing at validation as 1ES.DownloadPipelineArtifact@1 task is allowed only in release job, so added the job type as releaseJob (1ES pipeline template Inputs | 1ES On EngHub)

Motivation
Context

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Added relevant unit test for your changes. (yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • Ran precheckin (yarn precheckin)

@v-viyada v-viyada marked this pull request as ready for review December 19, 2024 00:12
@v-viyada v-viyada requested a review from a team as a code owner December 19, 2024 00:12
Copy link

@homitc homitc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@v-sharmachir v-sharmachir merged commit 65aa386 into main Dec 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants