Skip to content

Commit

Permalink
chore: Update validation pipelines to use v3 (#1324)
Browse files Browse the repository at this point in the history
#### Details

This PR will update the validation pipelines to use v3. This will allow
us to validate against the latest version of the action during release
validation. This PR will also update a baseline file to account for new
checks in the latest scan package.

##### Motivation

Required for validation.

##### Context

<!-- Are there any parts that you've intentionally left out-of-scope for
a later PR to handle? -->

<!-- Were there any alternative approaches you considered? What
tradeoffs did you consider? -->

#### Pull request checklist
<!-- If a checklist item is not applicable to this change, write "n/a"
in the checkbox -->
- [ ] Addresses an existing issue: Fixes #0000
- [ ] Added relevant unit test for your changes. (`yarn test`)
- [ ] Verified code coverage for the changes made. Check coverage report
at: `<rootDir>/test-results/unit/coverage`
- [ ] Ran precheckin (`yarn precheckin`)
- [ ] Described how this PR impacts both the ADO extension and the
GitHub action
  • Loading branch information
katydecorah authored Sep 30, 2022
1 parent 45f9dd6 commit 77aeeb7
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 8 deletions.
11 changes: 6 additions & 5 deletions dev/website-baselines/up-to-date-5858.baseline
Original file line number Diff line number Diff line change
Expand Up @@ -4,18 +4,19 @@
},
results: [
{
cssSelector: 'html',
htmlSnippet: '<html>',
rule: 'html-has-lang',
cssSelector: '#decorative',
htmlSnippet: '<img id="decorative" role="presentation" alt="Some alt text" src="./img1.png">',
rule: 'aria-allowed-role',
urls: [
'http://localhost:5858/',
],
},
{
cssSelector: 'html',
htmlSnippet: '<html><head>\n <title>Inner page</title>\n </head>\n <body>\n <main>\n <h1>Inner page with issues</h1>\n <img id="non-decorative" src="./img1.png">\n <a href="../">Back to home</a>\n </main>\n \n\n</body></html>',
htmlSnippet: '<html>',
rule: 'html-has-lang',
urls: [
'http://localhost:5858/',
'http://localhost:5858/linked1/inner-page',
],
},
Expand Down Expand Up @@ -53,4 +54,4 @@
],
},
],
}
}
2 changes: 1 addition & 1 deletion pipelines/ado-extension-canary-validation.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,4 @@ pool:
extends:
template: ado-extension-validation-template.yaml
parameters:
taskUnderTest: accessibility-insights.canary.task.accessibility-insights@2
taskUnderTest: accessibility-insights.canary.task.accessibility-insights@3
2 changes: 1 addition & 1 deletion pipelines/ado-extension-prod-validation.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,4 @@ pool:
extends:
template: ado-extension-validation-template.yaml
parameters:
taskUnderTest: accessibility-insights.prod.task.accessibility-insights@2
taskUnderTest: accessibility-insights.prod.task.accessibility-insights@3
2 changes: 1 addition & 1 deletion pipelines/ado-extension-staging-validation.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,4 @@ pool:
extends:
template: ado-extension-validation-template.yaml
parameters:
taskUnderTest: accessibility-insights.staging.task.accessibility-insights@2
taskUnderTest: accessibility-insights.staging.task.accessibility-insights@3

0 comments on commit 77aeeb7

Please sign in to comment.