Skip to content

Commit

Permalink
feat(axe-core 4.8): Axe core version upgrade for Action (#2042)
Browse files Browse the repository at this point in the history
#### Details
Axe core version upgrade to 4.8.4 for Accessibility Insights for Action

##### Motivation
Upgrade the axe core version to latest 4.8.4 in Accessibility Insights
for Action.
Also update accessibility insights scan and report packages with latest
versions which has axe-core version 4.8.4
<!-- This can be as simple as "addresses issue #123" -->

User story - [User Story
2157659](https://dev.azure.com/mseng/1ES/_workitems/edit/2157659)
##### Context

<!-- Are there any parts that you've intentionally left out-of-scope for
a later PR to handle? -->

<!-- Were there any alternative approaches you considered? What
tradeoffs did you consider? -->

#### Pull request checklist
<!-- If a checklist item is not applicable to this change, write "n/a"
in the checkbox -->
- [x] Addresses an existing issue: Fixes #0000
- [x] Added relevant unit test for your changes. (`yarn test`)
- [x] Verified code coverage for the changes made. Check coverage report
at: `<rootDir>/test-results/unit/coverage`
- [x] Ran precheckin (`yarn precheckin`)

---------

Co-authored-by: Vikash Yadav <[email protected]>
  • Loading branch information
SaanicaG and v-viyada authored May 30, 2024
1 parent b66b329 commit 27c7a09
Show file tree
Hide file tree
Showing 6 changed files with 236 additions and 195 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,5 @@ URLs: 1 with failures, 0 passed, 0 not scannable
Rules: 5 with failures, 14 passed, 36 not applicable
-------------------
This scan used axe-core 4.7.2"
This scan used axe-core 4.8.4"
`;
2 changes: 1 addition & 1 deletion packages/ado-extension/e2e/ado-extension.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ describe('Sample task tests', () => {
expect(testSubject.stdOutContained("##[debug][Telemetry] tracking a 'ScanCompleted' event"));

function filterStdOut(stdout: string) {
const logs = stdout.match(/-------------------(.|\n)*This scan used axe-core 4\.7\.2/);
const logs = stdout.match(/-------------------(.|\n)*This scan used axe-core 4\.8\.4/);
return logs ? logs[0] : '';
}
});
Expand Down
6 changes: 3 additions & 3 deletions packages/shared/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@
"dependencies": {
"@types/react": "^18.3",
"@types/react-dom": "^16.9",
"accessibility-insights-report": "4.7.3",
"accessibility-insights-scan": "2.5.1",
"axe-core": "4.7.2",
"accessibility-insights-report": "4.8.0",
"accessibility-insights-scan": "2.7.0",
"axe-core": "4.8.4",
"express": "^4.19.2",
"filenamify-url": "^3.1.0",
"get-port": "^7.1.0",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,25 +1,29 @@
Accessibility Insights
* URLs: 1 URL(s) failed, 1 URL(s) passed, and 1 were not scannable
* Rules: 99 check(s) failed, 1 check(s) passed, and 2 were not applicable
* Rules: 103 check(s) failed, 1 check(s) passed, and 2 were not applicable
* Download the Accessibility Insights artifact to view the detailed results of these checks
Failed instances
* 1 × accesskeys: Ensures every accesskey attribute value is unique
* 1 × area-alt: Ensures <area> elements of image maps have alternate text
* 1 × aria-allowed-attr: Ensures ARIA attributes are allowed for an element's role
* 1 × aria-allowed-attr: Ensures an element's role supports its ARIA attributes
* 1 × aria-allowed-role: Ensures role attribute has an appropriate value for the element
* 1 × aria-braille-equivalent: Ensure aria-braillelabel and aria-brailleroledescription have a non-braille equivalent
* 1 × aria-command-name: Ensures every ARIA button, link and menuitem has an accessible name
* 1 × aria-conditional-attr: Ensures ARIA attributes are used as described in the specification of the element's role
* 1 × aria-deprecated-role: Ensures elements do not use deprecated roles
* 1 × aria-dialog-name: Ensures every ARIA dialog and alertdialog node has an accessible name
* 1 × aria-hidden-body: Ensures aria-hidden='true' is not present on the document body.
* 1 × aria-hidden-body: Ensures aria-hidden="true" is not present on the document body.
* 1 × aria-hidden-focus: Ensures aria-hidden elements are not focusable nor contain focusable elements
* 1 × aria-input-field-name: Ensures every ARIA input field has an accessible name
* 1 × aria-meter-name: Ensures every ARIA meter node has an accessible name
* 1 × aria-progressbar-name: Ensures every ARIA progressbar node has an accessible name
* 1 × aria-prohibited-attr: Ensures ARIA attributes are not prohibited for an element's role
* 1 × aria-required-attr: Ensures elements with ARIA roles have all required ARIA attributes
* 1 × aria-required-children: Ensures elements with an ARIA role that require child roles contain them
* 1 × aria-required-parent: Ensures elements with an ARIA role that require parent roles are contained by them
* 1 × aria-roledescription: Ensure aria-roledescription is only used on elements with an implicit or explicit role
* 1 × aria-roles: Ensures all elements with a role attribute use a valid value
* 1 × aria-text: Ensures "role=text" is used on elements with no focusable descendants
* 1 × aria-text: Ensures role="text" is used on elements with no focusable descendants
* 1 × aria-toggle-field-name: Ensures every ARIA toggle field has an accessible name
* 1 × aria-tooltip-name: Ensures every ARIA tooltip node has an accessible name
* 1 × aria-treeitem-name: Ensures every ARIA treeitem node has an accessible name
Expand Down Expand Up @@ -86,7 +90,7 @@ Failed instances
* 1 × page-has-heading-one: Ensure that the page, or at least one of its frames contains a level-one heading
* 1 × presentation-role-conflict: Elements marked as presentational should not have global ARIA or tabindex to ensure all screen readers ignore them
* 1 × region: Ensures all page content is contained by landmarks
* 1 × role-img-alt: Ensures [role='img'] elements have alternate text
* 1 × role-img-alt: Ensures [role="img"] elements have alternate text
* 1 × scope-attr-valid: Ensures the scope attribute is used correctly on tables
* 1 × scrollable-region-focusable: Ensure elements that have scrollable content are accessible by keyboard
* 1 × select-name: Ensures select element has an accessible name
Expand Down
Original file line number Diff line number Diff line change
@@ -1,25 +1,29 @@
### ![Accessibility Insights](https://accessibilityinsights.io/img/a11yinsights-blue.svg) Accessibility Insights
* **URLs**: 1 URL(s) failed, 1 URL(s) passed, and 1 were not scannable
* **Rules**: 99 check(s) failed, 1 check(s) passed, and 2 were not applicable
* **Rules**: 103 check(s) failed, 1 check(s) passed, and 2 were not applicable
* Download the **Accessibility Insights artifact** to view the detailed results of these checks
#### Failed instances
* **1 × accesskeys**: Ensures every accesskey attribute value is unique
* **1 × area-alt**: Ensures \<area> elements of image maps have alternate text
* **1 × aria-allowed-attr**: Ensures ARIA attributes are allowed for an element's role
* **1 × aria-allowed-attr**: Ensures an element's role supports its ARIA attributes
* **1 × aria-allowed-role**: Ensures role attribute has an appropriate value for the element
* **1 × aria-braille-equivalent**: Ensure aria-braillelabel and aria-brailleroledescription have a non-braille equivalent
* **1 × aria-command-name**: Ensures every ARIA button, link and menuitem has an accessible name
* **1 × aria-conditional-attr**: Ensures ARIA attributes are used as described in the specification of the element's role
* **1 × aria-deprecated-role**: Ensures elements do not use deprecated roles
* **1 × aria-dialog-name**: Ensures every ARIA dialog and alertdialog node has an accessible name
* **1 × aria-hidden-body**: Ensures aria-hidden='true' is not present on the document body.
* **1 × aria-hidden-body**: Ensures aria-hidden="true" is not present on the document body.
* **1 × aria-hidden-focus**: Ensures aria-hidden elements are not focusable nor contain focusable elements
* **1 × aria-input-field-name**: Ensures every ARIA input field has an accessible name
* **1 × aria-meter-name**: Ensures every ARIA meter node has an accessible name
* **1 × aria-progressbar-name**: Ensures every ARIA progressbar node has an accessible name
* **1 × aria-prohibited-attr**: Ensures ARIA attributes are not prohibited for an element's role
* **1 × aria-required-attr**: Ensures elements with ARIA roles have all required ARIA attributes
* **1 × aria-required-children**: Ensures elements with an ARIA role that require child roles contain them
* **1 × aria-required-parent**: Ensures elements with an ARIA role that require parent roles are contained by them
* **1 × aria-roledescription**: Ensure aria-roledescription is only used on elements with an implicit or explicit role
* **1 × aria-roles**: Ensures all elements with a role attribute use a valid value
* **1 × aria-text**: Ensures "role=text" is used on elements with no focusable descendants
* **1 × aria-text**: Ensures role="text" is used on elements with no focusable descendants
* **1 × aria-toggle-field-name**: Ensures every ARIA toggle field has an accessible name
* **1 × aria-tooltip-name**: Ensures every ARIA tooltip node has an accessible name
* **1 × aria-treeitem-name**: Ensures every ARIA treeitem node has an accessible name
Expand Down Expand Up @@ -86,7 +90,7 @@
* **1 × page-has-heading-one**: Ensure that the page, or at least one of its frames contains a level-one heading
* **1 × presentation-role-conflict**: Elements marked as presentational should not have global ARIA or tabindex to ensure all screen readers ignore them
* **1 × region**: Ensures all page content is contained by landmarks
* **1 × role-img-alt**: Ensures [role='img'] elements have alternate text
* **1 × role-img-alt**: Ensures [role="img"] elements have alternate text
* **1 × scope-attr-valid**: Ensures the scope attribute is used correctly on tables
* **1 × scrollable-region-focusable**: Ensure elements that have scrollable content are accessible by keyboard
* **1 × select-name**: Ensures select element has an accessible name
Expand Down
Loading

0 comments on commit 27c7a09

Please sign in to comment.