Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed BADCLIENT error message #60925

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Conversation

armanio123
Copy link
Member

There's been an increase in telemetry reports on this error message, but the content is missing the exception message and the diagnostics codes.

i.e.

Error processing request. BADCLIENT: Bad error code, 7044 not found in range 139412..139415 (found: false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, fals...

This PR filter out the boolean values only to show the codes and repositions the exception message to the beginning because of truncation.

Also, all of the "exception messages" received are blank. I suspect that the exception is not an error, so I have added to check for the instance of Error as well.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jan 7, 2025
@andrewbranch
Copy link
Member

(Looks good except needs lint fix)

@armanio123
Copy link
Member Author

Lint fixed.

@armanio123 armanio123 merged commit 717d05c into microsoft:main Jan 7, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants