Ignore silentNever
in intersections with other meaningful constituents
#60876
+224
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not confident in this at all. I'm treating this as an experiment and I wonder if extended tests can reveal some missing test cases that should be added to the codebase.
The problem is that with a
contextualType
likeV["someArg"] | ((number | Variable<number, any>) & V["someArg"])
whenV
gets instantiated withsilentNeverType
the whole thing becomes... well,silentNeverType
. The repro in question is also somewhat interesting because all the involved types come fromV
:In the code above
GenericType
gets instantiated withV
. In general,GenericType
bit gets converted to its constraint when a contextual type of its~ property is requested. But the mapped type that iterated over stays somewhat deferred asV["someArg"]
and further down the line that creates a problem.fixes #60864