fix(60551): satisfies is shown on go-to-implementation (#60801)

microsoft · Jan 17, 2025 · f99803d · f99803d
1 parent 32e8f8b
commit f99803d
Show file tree

Hide file tree

Showing 3 changed files with 44 additions and 1 deletion.
diff --git a/src/services/findAllReferences.ts b/src/services/findAllReferences.ts
@@ -179,6 +179,7 @@ import {
     isReferencedFile,
     isReferenceFileLocation,
     isRightSideOfPropertyAccess,
+    isSatisfiesExpression,
     isShorthandPropertyAssignment,
     isSourceFile,
     isStatement,
@@ -2282,7 +2283,7 @@ export namespace Core {
                     addIfImplementation(body);
                 }
             }
-            else if (isAssertionExpression(typeHavingNode)) {
+            else if (isAssertionExpression(typeHavingNode) || isSatisfiesExpression(typeHavingNode)) {
                 addIfImplementation(typeHavingNode.expression);
             }
         }

diff --git a/tests/baselines/reference/goToImplementation_satisfies.baseline.jsonc b/tests/baselines/reference/goToImplementation_satisfies.baseline.jsonc
@@ -0,0 +1,30 @@
+// === goToImplementation ===
+// === /a.ts ===
+// interface /*GOTO IMPL*/I {
+// 	foo: string;
+// }
+// 
+// function f() {
+//     const foo = [|{ foo: '' }|] satisfies I;
+// }
+
+  // === Details ===
+  [
+   {
+    "kind": "interface",
+    "displayParts": [
+     {
+      "text": "(",
+      "kind": "punctuation"
+     },
+     {
+      "text": "object literal",
+      "kind": "text"
+     },
+     {
+      "text": ")",
+      "kind": "punctuation"
+     }
+    ]
+   }
+  ]
diff --git a/tests/cases/fourslash/goToImplementation_satisfies.ts b/tests/cases/fourslash/goToImplementation_satisfies.ts
@@ -0,0 +1,12 @@
+/// <reference path='fourslash.ts'/>
+
+// @filename: /a.ts
+////interface /*def*/I {
+////	foo: string;
+////}
+////
+////function f() {
+////    const foo = { foo: '' } satisfies [|I|];
+////}
+
+verify.baselineGoToImplementation('def');