<ranges>: Fix dispatching for views::counted
#5223
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanTLavavej
requested changes
Jan 6, 2025
| using value_type = std::iter_value_t<It>; | ||
| using difference_type = Diff; | ||
| using value_type = std::iter_value_t<It>; | ||
| using difference_type = Diff; | ||
|
|
||
| redifference_iterator() = default; | ||
| constexpr explicit redifference_iterator(It it) : i_{std::move(it)} {} |
There was a problem hiding this comment.
There are x64 test failures, separate from the x86 AV problem that's currently blocking all PR checks:
"C:\a\_work\1\s\tests\std\include\range_algorithm_support.hpp", line 989:
error: "i_" is not a nonstatic data member or base class of class
"test::redifference_iterator<std::_Signed128,
There was a problem hiding this comment.
P0896R4_views_counted is still failing. As a reminder, it's always a good idea to rerun a failing test locally before pushing changes.
There was a problem hiding this comment.
Oh, this is perphaps DevCom-10735214. The workaround seems to be making the function templates non-abbreviated. I'll verify whether such workaround suffices later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5183 (which is a bit beyond good first issue, IMO).
Drive-by changes:
test::redifference_iterator, which should always haveiterator_concept.P0896R4_views_counted/test.cpp.There's a bug of MSVC which forbids
using ranges::contiguous_range; contiguous_range auto cat = meow();to work. I've reported DevCom-10823410 for it.