[PTRun][Calc]Improve handling of non-base 10 numbers #36700
+9
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
CalculateHelper.InputValid()
0X
) inCalculateHelper.InputValid()
PR Checklist
Detailed Description of the Pull Request / Additional comments
The Mages dep has been recently upgraded to v3.0.0, introducing support for octal numbers and hence requiring this PR. Therefore it would be great if it got merged in this release cycle, so that there wouldn't be a release with v3.0.0 that doesn't properly support it.
Validation Steps Performed
Manually tested in PTRun + added tests