[AOT] clean up AOT issue in Settings.UI #36559
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moooyo
added
the
Needs-Review
Sergio0694
reviewed
Dec 25, 2024
| @@ -18,7 +18,7 @@ internal struct INPUT | |||
|
|
|||
| internal static int Size | |||
| { | |||
| get { return Marshal.SizeOf(typeof(INPUT)); } | |||
| get { return Marshal.SizeOf<INPUT>(); } | |||
There was a problem hiding this comment.
Is INPUT blittable? If so you should just do sizeof(INPUT). Same for all other Marshal.SizeOf uses in this PR.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
added 3 commits
January 20, 2025 17:50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
PR Checklist
Manual test passed. If we need any addtional test, please let me know.
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed