Handle nullish coalescing assignment and else case assignment in no-unchecked-record access #23633
+269
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: build
There was a problem hiding this comment.
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
Files not reviewed (1)
- common/build/eslint-plugin-fluid/package.json: Language not supported
Comments suppressed due to low confidence (2)
common/build/eslint-plugin-fluid/src/test/example/no-unchecked-record-access/indexedRecordOfStrings.ts:116
- The variable 'oldData' is declared but never used. It should be removed to keep the code clean.
const oldData = mergedData[valueManagerKey][nestedDataKey];
common/build/eslint-plugin-fluid/src/test/example/no-unchecked-record-access/indexedRecordOfStrings.ts:133
- Ensure 'datastore[key]' is defined before accessing it. Add a check or assignment to ensure it is defined.
datastore[key][key] = {};
scottn12
reviewed
Jan 23, 2025
common/build/eslint-plugin-fluid/src/rules/no-unchecked-record-access.js
Outdated
Show resolved
Hide resolved
common/build/eslint-plugin-fluid/src/rules/no-unchecked-record-access.js
Outdated
Show resolved
Hide resolved
common/build/eslint-plugin-fluid/src/rules/no-unchecked-record-access.js
Outdated
Show resolved
Hide resolved
common/build/eslint-plugin-fluid/src/rules/no-unchecked-record-access.js
Show resolved
Hide resolved
common/build/eslint-plugin-fluid/src/rules/no-unchecked-record-access.js
Outdated
Show resolved
Hide resolved
Josmithr
reviewed
Jan 23, 2025
common/build/eslint-plugin-fluid/src/rules/no-unchecked-record-access.js
Outdated
Show resolved
Hide resolved
Josmithr
reviewed
Jan 23, 2025
common/build/eslint-plugin-fluid/src/rules/no-unchecked-record-access.js
Outdated
Show resolved
Hide resolved
jikim-msft
reviewed
Jan 25, 2025
| // Additional check for 'in' checks in the same scope | ||
| const containingBlock = findContainingBlock(current); | ||
| if (containingBlock) { | ||
| for (const stmt of containingBlock.body) { |
There was a problem hiding this comment.
Can you replace the abbreviation stmt to its full name?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handle nullish coalescing assignment and else case assignment in no-unchecked-record access