eslint(container-runtime): Prefix container-runtime before enabling no-unchecked-record-access #23437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o-unchecked-record-access
github-actions
bot
added
base: main
There was a problem hiding this comment.
Copilot reviewed 5 out of 12 changed files in this pull request and generated no comments.
Files not reviewed (7)
- packages/runtime/container-runtime/src/blobManager/blobManagerSnapSum.ts: Evaluated as low risk
- packages/runtime/container-runtime/src/channelCollection.ts: Evaluated as low risk
- packages/runtime/container-runtime/src/containerRuntime.ts: Evaluated as low risk
- packages/runtime/container-runtime/src/gc/garbageCollection.ts: Evaluated as low risk
- packages/runtime/container-runtime/src/gc/gcConfigs.ts: Evaluated as low risk
- packages/runtime/container-runtime/src/gc/gcHelpers.ts: Evaluated as low risk
- packages/runtime/container-runtime/src/gc/gcReferenceGraphAlgorithm.ts: Evaluated as low risk
Comments suppressed due to low confidence (1)
packages/runtime/container-runtime/src/test/gc/garbageCollection.spec.ts:1958
- Ensure defaultGCData.gcNodes[nodeA] is initialized before pushing. Add a check to initialize it if undefined.
defaultGCData.gcNodes[nodeA]?.push(nodeD);
markfields
reviewed
Jan 6, 2025
| @@ -1951,7 +1955,7 @@ describe("Garbage Collection Tests", () => { | |||
| defaultGCData.gcNodes[nodeE] = [nodeA]; | |||
|
|
|||
| // 4. Add reference from A to D with calling addedOutboundReference | |||
| defaultGCData.gcNodes[nodeA].push(nodeD); | |||
| defaultGCData.gcNodes[nodeA]?.push(nodeD); | |||
There was a problem hiding this comment.
Why is this a ? now, that seems problematic
| @@ -4170,7 +4171,7 @@ export class ContainerRuntime | |||
| // Counting dataStores and handles | |||
| // Because handles are unchanged dataStores in the current logic, | |||
| // summarized dataStore count is total dataStore count minus handle count | |||
| const dataStoreTree = summaryTree.tree[channelsTreeName]; | |||
| const dataStoreTree: SummaryObject | undefined = summaryTree.tree[channelsTreeName]; | |||
|
|
|||
| assert(dataStoreTree.type === SummaryType.Tree, 0x1fc /* "summary is not a tree" */); | |||
There was a problem hiding this comment.
How does this not throw? Doesn't this need to be dataStoreTree?.type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eslint(container-runtime): Prefix container-runtime before enabling no-unchecked-record-access
AB#25378