Change shares api path to match other use cases #23434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: driver
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
packages/drivers/odsp-driver/src/getFileLink.ts:105
- The word 'getFilelink' should be corrected to 'getFileLink'.
* Handles location redirection while fulfilling the getFileLink call. We don't want browser to handle
jatgarg
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
odsp-driver calls '/shares' API to redeem access to file referenced by redeemable sharing link. I am changing API path to include '/driveItem' in it. Technically it is not required for executing redeem operation. However, we have other cases that use '/shares' API and do require to specify '/driveItem' in order to get specific drive item properties. The reason this matter is when caller of this API must possess logical permissions to call this API (for instance, this will be the case when call is made with app-only token) then two separate logical permissions are needed for the '/shares' call with and without '/driveItem'.
Reviewer Guidance
The review process is outlined on this wiki page.