eslint(telemetry-utils): Prefix telemetry-utils before enabling no-unchecked-record-access #23428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hecked-record-access
RishhiB
changed the title
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
markfields
reviewed
Jan 6, 2025
| const actualValue: | ||
| | TelemetryEventPropertyTypeExt | ||
| | Tagged<TelemetryEventPropertyTypeExt> | ||
| | undefined = actual[expectedKey]; |
There was a problem hiding this comment.
Woah is this really what the formatter wants? I am not a fan of how the RHS of the = is on the same line as the end of that multi-line type. Weird, oh well.
markfields
reviewed
Jan 6, 2025
| @@ -22,7 +22,8 @@ const getMockStore = (settings: Record<string, string>): Storage => { | |||
| return { | |||
| getItem: (key: string): string | null => { | |||
| ops.push(key); | |||
| return settings[key]; | |||
| // eslint-disable-next-line unicorn/no-null | |||
| return settings[key] ?? null; | |||
There was a problem hiding this comment.
What's the rationale here? Is the calling code prepared to handle null instead of undefined?
There was a problem hiding this comment.
yes, getItem is typed to string | null, but returning settings[key] results in a type of string | undefined, so I just force it to null if its undefined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eslint(telemetry-utils): Prefix telemetry-utils before enabling no-unchecked-record-access
AB#25378