clone list of revertibles #23424
Open
clone list of revertibles #23424
+121
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: dds
WayneFerrao
reviewed
Jan 3, 2025
WayneFerrao
reviewed
Jan 3, 2025
seanimam
reviewed
Jan 6, 2025
jenn-le
reviewed
Jan 6, 2025
packages/dds/tree/src/test/utils.ts
Outdated
| * @param targetBranch - The target branch to clone the revertibles for | ||
| * @returns Array of cloned revertibles, maintaining the same order as the input | ||
| */ | ||
| export function cloneRevertiblesInBatch( |
There was a problem hiding this comment.
This needs to be package exported for users to be able to use it
There was a problem hiding this comment.
Made changes while you were reviewing 😄. Would you look into this again please?
jenn-le
reviewed
Jan 6, 2025
jenn-le
reviewed
Jan 6, 2025
github-actions
bot
added
the
area: framework
|
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output |
Comment on lines
+689
to
+692
| const batchedRevertibles: RevertibleAlpha[] = []; | ||
| for (const revertible of undoStack) { | ||
| batchedRevertibles.push(revertible); | ||
| } |
There was a problem hiding this comment.
Is there a reason not to just do const batchedRevertibles = [...undoStack];
Comment on lines
+617
to
+624
| // Check if the original branch and forked branch have a common ancestor. | ||
| const originalBranchHead = this.#transaction.activeBranch.getHead(); | ||
| const forkedBranchHead = forkedCheckout.#transaction.activeBranch.getHead(); | ||
|
|
||
| assert( | ||
| findCommonAncestor(originalBranchHead, forkedBranchHead) !== undefined, | ||
| 0x576 /* branch A and branch B must be related */, | ||
| ); |
There was a problem hiding this comment.
This should be done in a separate PR, and it should throw a UsageError instead of asserting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
13865
This PR adds a helper function that takes in the list of revertibles and returns the cloned revertibles in order.