Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

target es2021 #23307

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

target es2021 #23307

wants to merge 8 commits into from

Conversation

CraigMacomber
Copy link
Contributor

@CraigMacomber CraigMacomber commented Dec 12, 2024

Description

Target es2021.

This should reduce bundle size a little by allowing TypeScript to use slightly newer language features.

Breaking Changes

According to https://github.com/microsoft/FluidFramework/blob/main/ClientRequirements.md to require customers to have es2022 support or polyfill, so this should be allowed.

This does NOT change the "lib" version, so customers should not need to add new library polyfills and does not change what APIs are allowed to be used in our code: this only updates the language version to allow using newer language features.

As we don't actually have any tooling in place to prevent our dependencies from using newer language (or library) features, its likely we already implicitly have this requirement.

Reviewer Guidance

The review process is outlined on this wiki page.

@github-actions github-actions bot added area: build Build related issues area: contributor experience public api change Changes to a public API base: main PRs targeted against main branch labels Dec 12, 2024
@CraigMacomber CraigMacomber marked this pull request as ready for review January 9, 2025 19:14
@Copilot Copilot bot review requested due to automatic review settings January 9, 2025 19:14
@CraigMacomber CraigMacomber requested a review from a team as a code owner January 9, 2025 19:14

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • common/build/build-common/tsconfig.base.json: Language not supported
Copy link
Contributor

github-actions bot commented Jan 9, 2025

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> [email protected] ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> [email protected] serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> [email protected] check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  170508 links
    1603 destination URLs
    1842 URLs ignored
       0 warnings
       0 errors


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: build Build related issues base: main PRs targeted against main branch public api change Changes to a public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant