-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
target es2021 #23307
Open
CraigMacomber
wants to merge
8
commits into
microsoft:main
Choose a base branch
from
CraigMacomber:2021
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
target es2021 #23307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: build
Build related issues
area: contributor experience
public api change
Changes to a public API
base: main
PRs targeted against main branch
labels
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
Files not reviewed (1)
- common/build/build-common/tsconfig.base.json: Language not supported
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: build
Build related issues
base: main
PRs targeted against main branch
public api change
Changes to a public API
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Target es2021.
This should reduce bundle size a little by allowing TypeScript to use slightly newer language features.
Breaking Changes
According to https://github.com/microsoft/FluidFramework/blob/main/ClientRequirements.md to require customers to have es2022 support or polyfill, so this should be allowed.
This does NOT change the "lib" version, so customers should not need to add new library polyfills and does not change what APIs are allowed to be used in our code: this only updates the language version to allow using newer language features.
As we don't actually have any tooling in place to prevent our dependencies from using newer language (or library) features, its likely we already implicitly have this requirement.
Reviewer Guidance
The review process is outlined on this wiki page.