-
Notifications
You must be signed in to change notification settings - Fork 535
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'main' into test/tianzhu/add-pe-alfred
- Loading branch information
Showing
148 changed files
with
1,278 additions
and
1,881 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
--- | ||
"@fluidframework/aqueduct": minor | ||
"@fluid-experimental/attributor": minor | ||
"@fluidframework/container-runtime": minor | ||
"@fluidframework/test-utils": minor | ||
--- | ||
--- | ||
"section": legacy | ||
--- | ||
|
||
ContainerRuntime class is no longer exported | ||
|
||
Use `IContainerRuntime` to replace type usages and use the free function `loadContainerRuntime` to replace usages of the static method `ContainerRuntime.loadRuntime`. | ||
|
||
See the [deprecation release note](https://github.com/microsoft/FluidFramework/releases/tag/client_v2.12.0#user-content-the-containerruntime-class-is-now-deprecated-23331) for more details. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
--- | ||
"@fluidframework/container-runtime": minor | ||
--- | ||
--- | ||
"section": legacy | ||
--- | ||
|
||
IContainerRuntimeOptions.flushMode has been removed | ||
|
||
See [2.12.0 release note](https://github.com/microsoft/FluidFramework/releases/tag/client_v2.12.0#user-content-icontainerruntimeoptionsflushmode-is-now-deprecated-23288) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
--- | ||
"@fluidframework/aqueduct": minor | ||
"@fluidframework/container-runtime": minor | ||
"@fluidframework/container-runtime-definitions": minor | ||
"@fluidframework/datastore": minor | ||
"@fluidframework/runtime-definitions": minor | ||
"@fluidframework/test-runtime-utils": minor | ||
--- | ||
|
||
# The createDataStoreWithProps APIs on ContainerRuntime and IContainerRuntimeBase have been removed | ||
|
||
`ContainerRuntime.createDataStoreWithProps` and `IContainerRuntimeBase.createDataStoreWithProps` | ||
have been removed. | ||
|
||
Replace uses of these APIs with `PureDataObjectFactory.createInstanceWithDataStore` and pass in props via the `initialState` | ||
parameter. | ||
|
||
# Initial deprecation/removal announcement | ||
|
||
The initial deprecations of the now changed or removed types were announced [#1537](https://github.com/microsoft/FluidFramework/issues/1537) | ||
in Fluid Framework v0.25 [#2931](https://github.com/microsoft/FluidFramework/pull/2931) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
--- | ||
"@fluidframework/shared-object-base": minor | ||
--- | ||
--- | ||
"section": legacy | ||
--- | ||
|
||
Replace 'any' in return type for several APIs | ||
|
||
To improve type safety of the Fluid Framework legacy+alpha API surface, | ||
we're moving away from using the `any` type in favor of `unknown`. | ||
|
||
We mostly expect that any changes required in consumers of these APIs will be limited to having to provide explicit types | ||
when calling any of the APIs whose return value changed to `unknown`, like `IFluidSerializer.parse()`. | ||
|
||
So code that looked like this: | ||
|
||
```typescript | ||
// 'myVariable' ended up typed as 'any' here and TypeScript would not do any type-safety checks on it. | ||
const myVariable = this.serializer.parse(stringHeader); | ||
``` | ||
|
||
Will now have to look like this: | ||
|
||
```typescript | ||
// Do this if you know the type of the object you expect to get back. | ||
const myVariable = this.serializer.parse(stringHeader) as MyType; | ||
|
||
// Alternatively, this will maintain current behavior but also means no type-safety checks will be done by TS. | ||
// const myVariable = this.serializer.parse(stringHeader) as any; | ||
``` | ||
|
||
The appropriate type will depend on what the calling code is doing and the objects it expects to be dealing with. | ||
|
||
We further encourage consumers of any of these APIs to add runtime checks | ||
to validate that the returned object actually matches the expected type. | ||
|
||
The list of affected APIs is as follows: | ||
|
||
- `IFluidSerializer.encode(...)` now takes `value: unknown` instead of `value: any` and returns `unknown` instead of `any`. | ||
- `IFluidSerializer.decode(...)` now takes `input: unknown` instead of `input: any` and returns `unknown` instead of `any`. | ||
- `IFluidSerializer.stringify(...)` now takes `value: unknown` instead of `value: any`. | ||
- `IFluidSerializer.parse(...)` now returns `unknown` instead of `any`. | ||
- `SharedObjectCore.applyStashedOps(...)` now takes `content: unknown` instead of `content: any`. | ||
- `SharedObjectCore.rollback(...)` now takes `content: unknown` instead of `content: any`. | ||
- `SharedObjectCore.submitLocalMessage(...)` now takes `content: unknown` instead of `content: any`. | ||
- `SharedObjectCore.reSubmitCore(...)` now takes `content: unknown` instead of `content: any`. | ||
- In `SharedObjectCore.newAckBasedPromise<T>(...)` the `executor` parameter now takes `reject: (reason?: unknown)` | ||
instead of `reject: (reason?: any)`. | ||
- `makeHandlesSerializable(...)` now returns `unknown` instead of `any`. | ||
- `parseHandles(...)` now returns `unknown` instead of `any`. | ||
|
||
Additionally, the following APIs were never designed to return a value and have thus been updated to return `void` instead of `any`: | ||
|
||
- `SharedObjectCore.processCore(...)`. | ||
- `SharedObjectCore.onDisconnect(...)` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
260 changes: 0 additions & 260 deletions
260
build-tools/packages/build-cli/src/library/repoPolicyCheck/assertShortCode.ts
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
{ | ||
"type": "commonjs" | ||
"type": "commonjs", | ||
"sideEffects": false | ||
} |
Oops, something went wrong.