Prefix trivial issues when enabling no-unchecked-record-access for cl…

…ient packages (#23432)

Prefix trivial issues when enabling no-unchecked-record-access for
client packages

[AB#25378](https://dev.azure.com/fluidframework/235294da-091d-4c29-84fc-cdfc3d90890b/_workitems/edit/25378)

---------

Co-authored-by: Abram Sanderson <[email protected]>

experimental/dds/attributable-map/src/mapKernel.ts

@@ -216,7 +216,7 @@ export class AttributableMapKernel {
 				return nextVal.done
 					? { value: undefined, done: true }
 					: // Unpack the stored value
-						{ value: [nextVal.value[0], nextVal.value[1].value], done: false };
+						{ value: [nextVal.value[0], nextVal.value[1]?.value], done: false };
 			},
 			[Symbol.iterator](): IterableIterator<[string, unknown]> {
 				return this;

packages/dds/map/src/directory.ts

@@ -1607,7 +1607,7 @@ class SubDirectory extends TypedEventEmitter<IDirectoryEvents> implements IDirec
 				const nextVal = localEntriesIterator.next();
 				return nextVal.done
 					? { value: undefined, done: true }
-					: { value: [nextVal.value[0], nextVal.value[1].value], done: false };
+					: { value: [nextVal.value[0], nextVal.value[1]?.value], done: false };
 			},
 			[Symbol.iterator](): IterableIterator<[string, unknown]> {
 				return this;

packages/dds/map/src/mapKernel.ts

@@ -208,7 +208,7 @@ export class MapKernel {
 				return nextVal.done
 					? { value: undefined, done: true }
 					: // Unpack the stored value
-						{ value: [nextVal.value[0], nextVal.value[1].value], done: false };
+						{ value: [nextVal.value[0], nextVal.value[1]?.value], done: false };
 			},
 			[Symbol.iterator](): IterableIterator<[string, unknown]> {
 				return this;

packages/dds/map/src/test/mocha/directory.spec.ts

@@ -104,12 +104,12 @@ function serialize(directory1: ISharedDirectory): string {
 	assert.strictEqual(summaryObjectKeys.length, 1, "summary tree should only have one blob");
 	assert.strictEqual(summaryObjectKeys[0], "header", "summary should have a header blob");
 	assert.strictEqual(
-		summaryTree.tree.header.type,
+		summaryTree.tree.header?.type,
 		SummaryType.Blob,
 		"header is not of SummaryType.Blob",
 	);
 
-	const content = summaryTree.tree.header.content as string;
+	const content = summaryTree.tree.header?.content as string;
 	return JSON.stringify((JSON.parse(content) as IDirectoryNewStorageFormat).content);
 }
 
@@ -1725,15 +1725,15 @@ describe("Directory", () => {
 				const fooSubDirIterator = fooSubDir.entries();
 				const fooSubDirResult1 = fooSubDirIterator.next();
 				// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
-				assert.equal(fooSubDirResult1.value[0], "testKey");
+				assert.equal(fooSubDirResult1.value?.[0], "testKey");
 				// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
-				assert.equal(fooSubDirResult1.value[1], "testValue");
+				assert.equal(fooSubDirResult1.value?.[1], "testValue");
 				assert.equal(fooSubDirResult1.done, false);
 				const fooSubDirResult2 = fooSubDirIterator.next();
 				// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
-				assert.equal(fooSubDirResult2.value[0], "testKey2");
+				assert.equal(fooSubDirResult2.value?.[0], "testKey2");
 				// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
-				assert.equal(fooSubDirResult2.value[1], "testValue2");
+				assert.equal(fooSubDirResult2.value?.[1], "testValue2");
 				assert.equal(fooSubDirResult2.done, false);
 				const fooSubDirResult3 = fooSubDirIterator.next();
 				assert.equal(fooSubDirResult3.value, undefined);
@@ -1755,15 +1755,15 @@ describe("Directory", () => {
 				const fooSubDir2Iterator = fooSubDir2.entries();
 				const fooSubDir2Result1 = fooSubDir2Iterator.next();
 				// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
-				assert.equal(fooSubDir2Result1.value[0], "testKey");
+				assert.equal(fooSubDir2Result1.value?.[0], "testKey");
 				// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
-				assert.equal(fooSubDir2Result1.value[1], "testValue");
+				assert.equal(fooSubDir2Result1.value?.[1], "testValue");
 				assert.equal(fooSubDir2Result1.done, false);
 				const fooSubDir2Result2 = fooSubDir2Iterator.next();
 				// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
-				assert.equal(fooSubDir2Result2.value[0], "testKey2");
+				assert.equal(fooSubDir2Result2.value?.[0], "testKey2");
 				// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
-				assert.equal(fooSubDir2Result2.value[1], "testValue2");
+				assert.equal(fooSubDir2Result2.value?.[1], "testValue2");
 				assert.equal(fooSubDir2Result2.done, false);
 				const fooSubDir2Result3 = fooSubDir2Iterator.next();
 				assert.equal(fooSubDir2Result3.value, undefined);

packages/dds/merge-tree/src/test/beastTest.spec.ts

@@ -1432,7 +1432,7 @@ export class DocumentTree {
 				});
 				this.pos++;
 			} else {
-				const trid = docNode.name + this.ids[docNode.name].toString();
+				const trid = docNode.name + this.ids[docNode.name]!.toString();
 				docNode.id = trid;
 				id = this.ids[docNode.name]++;
 				const props = {

packages/dds/sequence/src/revertibles.ts

@@ -340,7 +340,7 @@ export function appendSharedStringDeltaToRevertibles(
 
 				revertible.intervals.push({
 					intervalId: interval.getIntervalId(),
-					label: interval.properties.referenceRangeLabels[0],
+					label: interval.properties.referenceRangeLabels?.[0],
 					startOffset: offset,
 					endOffset,
 				});
@@ -350,7 +350,7 @@ export function appendSharedStringDeltaToRevertibles(
 			endIntervals.forEach(({ interval, offset }) => {
 				revertible.intervals.push({
 					intervalId: interval.getIntervalId(),
-					label: interval.properties.referenceRangeLabels[0],
+					label: interval.properties.referenceRangeLabels?.[0],
 					endOffset: offset,
 				});
 			});
@@ -432,7 +432,7 @@ function revertLocalAdd(
 	revertible: TypedRevertible<typeof IntervalOpType.ADD>,
 ) {
 	const id = getUpdatedIdFromInterval(revertible.interval);
-	const label = revertible.interval.properties.referenceRangeLabels[0];
+	const label = revertible.interval.properties.referenceRangeLabels?.[0];
 	string.getIntervalCollection(label).removeIntervalById(id);
 }
 
@@ -460,7 +460,7 @@ function revertLocalDelete(
 	string: ISharedString,
 	revertible: TypedRevertible<typeof IntervalOpType.DELETE>,
 ) {
-	const label = revertible.interval.properties.referenceRangeLabels[0];
+	const label = revertible.interval.properties.referenceRangeLabels?.[0];
 	const collection = string.getIntervalCollection(label);
 	const start = string.localReferencePositionToPosition(revertible.start);
 	const startSlidePos = getSlidePosition(string, revertible.start, start);
@@ -499,7 +499,7 @@ function revertLocalChange(
 	string: ISharedString,
 	revertible: TypedRevertible<typeof IntervalOpType.CHANGE>,
 ) {
-	const label = revertible.interval.properties.referenceRangeLabels[0];
+	const label = revertible.interval.properties.referenceRangeLabels?.[0];
 	const collection = string.getIntervalCollection(label);
 	const id = getUpdatedIdFromInterval(revertible.interval);
 	const start = string.localReferencePositionToPosition(revertible.start);
@@ -539,7 +539,7 @@ function revertLocalPropertyChanged(
 	string: ISharedString,
 	revertible: TypedRevertible<typeof IntervalOpType.PROPERTY_CHANGED>,
 ) {
-	const label = revertible.interval.properties.referenceRangeLabels[0];
+	const label = revertible.interval.properties.referenceRangeLabels?.[0];
 	const id = getUpdatedIdFromInterval(revertible.interval);
 	const newProps = revertible.propertyDeltas;
 	string.getIntervalCollection(label).change(id, { props: newProps });

packages/drivers/odsp-driver/src/WriteBufferUtils.ts

@@ -32,7 +32,7 @@ export class WriteBuffer {
 			let index = 0;
 			const oldData = this.data;
 			while (index < length) {
-				newData[index] = oldData[index];
+				newData[index] = oldData[index]!;
 				index++;
 			}
 			this.data = newData;
@@ -233,8 +233,8 @@ function serializeNodeCore(
 	for (const child of nodeCore.nodes) {
 		if (child instanceof NodeCore) {
 			// For a tree node start and end with set/list start and end marker codes.
-			const startCode = MarkerCodesStart[child.type];
-			const endCode = MarkerCodesEnd[child.type];
+			const startCode: MarkerCodesStart | undefined = MarkerCodesStart[child.type];
+			const endCode: MarkerCodesEnd | undefined = MarkerCodesEnd[child.type];
 			assert(startCode !== undefined, 0x285 /* "Start code should not undefined" */);
 			assert(endCode !== undefined, 0x286 /* "End code should not undefined" */);
 			buffer.write(startCode);

packages/drivers/odsp-driver/src/compactSnapshotParser.ts

@@ -72,7 +72,7 @@ function readBlobSection(node: NodeTypes): {
 			const records = getNodeProps(blob);
 			assertBlobCoreInstance(records.data, "data should be of BlobCore type");
 			const id = getStringInstance(records.id, "blob id should be string");
-			blobContents.set(id, records.data.arrayBuffer);
+			blobContents.set(id, records.data?.arrayBuffer);
 		}
 	}
 	return { blobContents, slowBlobStructureCount };
@@ -88,15 +88,15 @@ function readOpsSection(node: NodeTypes): ISequencedDocumentMessage[] {
 	const records = getNodeProps(node);
 	assertNumberInstance(records.firstSequenceNumber, "Seq number should be a number");
 	assertNodeCoreInstance(records.deltas, "Deltas should be a Node");
-	for (let i = 0; i < records.deltas.length; ++i) {
+	for (let i = 0; i < records.deltas?.length; ++i) {
 		// eslint-disable-next-line @typescript-eslint/no-unsafe-argument
-		ops.push(JSON.parse(records.deltas.getString(i)));
+		ops.push(JSON.parse(records.deltas?.getString(i)));
 	}
 	// Due to a bug at service side, in an edge case service was serializing deltas even
 	// when there are no ops. So just make the code resilient to that bug. Service has also
 	// fixed that bug.
 	assert(
-		ops.length === 0 || records.firstSequenceNumber.valueOf() === ops[0].sequenceNumber,
+		ops.length === 0 || records.firstSequenceNumber?.valueOf() === ops[0].sequenceNumber,
 		0x280 /* "Validate first op seq number" */,
 	);
 	return ops;
@@ -244,7 +244,7 @@ function readSnapshotSection(node: NodeTypes): {
 	const { snapshotTree, slowTreeStructureCount, treeStructureCountWithGroupId } =
 		readTreeSection(records.treeNodes);
 	snapshotTree.id = getStringInstance(records.id, "snapshotId should be string");
-	const sequenceNumber = records.sequenceNumber.valueOf();
+	const sequenceNumber = records.sequenceNumber?.valueOf();
 	return {
 		sequenceNumber,
 		snapshotTree,

packages/drivers/odsp-driver/src/odspDocumentStorageServiceBase.ts

@@ -257,8 +257,9 @@ export abstract class OdspDocumentStorageServiceBase implements IDocumentStorage
 	protected combineProtocolAndAppSnapshotTree(snapshotTree: ISnapshotTree): ISnapshotTree {
 		// When we upload the container snapshot, we upload appTree in ".app" and protocol tree in ".protocol"
 		// So when we request the snapshot we get ".app" as tree and not as commit node as in the case just above.
-		const hierarchicalAppTree = snapshotTree.trees[".app"];
-		const hierarchicalProtocolTree = snapshotTree.trees[".protocol"];
+		const hierarchicalAppTree: ISnapshotTree | undefined = snapshotTree.trees[".app"];
+		const hierarchicalProtocolTree: ISnapshotTree | undefined =
+			snapshotTree.trees[".protocol"];
 		const summarySnapshotTree: ISnapshotTree = {
 			blobs: {
 				...hierarchicalAppTree.blobs,

packages/drivers/odsp-driver/src/odspDriverUrlResolver.ts

@@ -108,7 +108,7 @@ export class OdspDriverUrlResolver implements IUrlResolver {
 
 			const searchParams = new URLSearchParams(queryString);
 			// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-member-access
-			const fileName: string = request.headers[DriverHeader.createNew].fileName;
+			const fileName: string = request.headers[DriverHeader.createNew]?.fileName;
 			const driveID = searchParams.get("driveId");
 			const filePath = searchParams.get("path");
 			const packageName = searchParams.get("containerPackageName");

packages/drivers/odsp-driver/src/test/createNewUtilsTests.spec.ts

@@ -7,7 +7,11 @@ import { strict as assert } from "node:assert";
 
 import { bufferToString, fromBase64ToUtf8 } from "@fluid-internal/client-utils";
 import { ISummaryTree, SummaryType } from "@fluidframework/driver-definitions";
-import { ISnapshot, IDocumentAttributes } from "@fluidframework/driver-definitions/internal";
+import {
+	ISnapshot,
+	IDocumentAttributes,
+	type ISnapshotTree,
+} from "@fluidframework/driver-definitions/internal";
 import {
 	IFileEntry,
 	IOdspResolvedUrl,
@@ -139,18 +143,18 @@ describe("Create New Utils Tests", () => {
 		);
 		assert.strictEqual(snapshot.blobContents.size, 2, "2 blobs should be there");
 
-		const appTree = snapshotTree.trees[".app"];
-		const protocolTree = snapshotTree.trees[".protocol"];
+		const appTree: ISnapshotTree | undefined = snapshotTree.trees[".app"];
+		const protocolTree: ISnapshotTree | undefined = snapshotTree.trees[".protocol"];
 		assert(appTree !== undefined, "App tree should be there");
 		assert(protocolTree !== undefined, "Protocol tree should be there");
 
-		const appTreeBlobId = appTree.blobs.attributes;
+		const appTreeBlobId: string | undefined = appTree.blobs.attributes;
 		const appTreeBlobValBuffer = snapshot.blobContents.get(appTreeBlobId);
 		assert(appTreeBlobValBuffer !== undefined, "app blob value should exist");
 		const appTreeBlobVal = bufferToString(appTreeBlobValBuffer, "utf8");
 		assert(appTreeBlobVal === blobContent, "Blob content should match");
 
-		const docAttributesBlobId = protocolTree.blobs.attributes;
+		const docAttributesBlobId: string | undefined = protocolTree.blobs.attributes;
 		const docAttributesBuffer = snapshot.blobContents.get(docAttributesBlobId);
 		assert(docAttributesBuffer !== undefined, "protocol attributes blob value should exist");
 		const docAttributesBlobValue = bufferToString(docAttributesBuffer, "utf8");

packages/drivers/odsp-driver/src/test/getUrlAndHeadersWithAuth.spec.ts

@@ -24,7 +24,7 @@ describe("getHeadersWithAuth", () => {
 		result: { [index: string]: string },
 	): void => {
 		assert.strictEqual(
-			result.Authorization.endsWith(token),
+			result.Authorization?.endsWith(token),
 			true,
 			"Returned header must contain token",
 		);

packages/drivers/odsp-driver/src/test/prefetchSnapshotTests.spec.ts

@@ -626,9 +626,9 @@ describe("Tests for prefetching snapshot", () => {
 		};
 		const odspCompactSnapshotWithGroupId = convertToCompactSnapshot(snapshotWithGroupId);
 		const snapshotTreeWithGroupIdToCompare: ISnapshotTree = {
-			blobs: { ...snapshotTreeWithGroupId.trees[".app"].blobs },
+			blobs: { ...snapshotTreeWithGroupId.trees[".app"]?.blobs },
 			trees: {
-				...snapshotTreeWithGroupId.trees[".app"].trees,
+				...snapshotTreeWithGroupId.trees[".app"]?.trees,
 				".protocol": snapshotTreeWithGroupId.trees[".protocol"],
 			},
 			id: "SnapshotId",
@@ -866,9 +866,9 @@ describe("Tests for prefetching snapshot", () => {
 		};
 		const odspCompactSnapshotWithGroupId = convertToCompactSnapshot(snapshotWithGroupId);
 		const snapshotTreeWithGroupIdToCompare: ISnapshotTree = {
-			blobs: { ...snapshotTreeWithGroupId.trees[".app"].blobs },
+			blobs: { ...snapshotTreeWithGroupId.trees[".app"]?.blobs },
 			trees: {
-				...snapshotTreeWithGroupId.trees[".app"].trees,
+				...snapshotTreeWithGroupId.trees[".app"]?.trees,
 				".protocol": snapshotTreeWithGroupId.trees[".protocol"],
 			},
 			id: "SnapshotId",

packages/drivers/replay-driver/src/storageImplementations.ts

@@ -80,9 +80,9 @@ export class FileSnapshotReader
 			throw new Error(`Unknown version id: ${versionRequested}`);
 		}
 
-		let snapshotTree = this.trees[versionRequested.id];
+		let snapshotTree: ISnapshotTree | undefined = this.trees[versionRequested.id];
 		if (snapshotTree === undefined) {
-			const tree = this.commits[versionRequested.id];
+			const tree: ITree | undefined = this.commits[versionRequested.id];
 			if (tree === undefined) {
 				throw new Error(`Can't find version ${versionRequested.id}`);
 			}

packages/drivers/routerlicious-driver/src/documentService.ts

@@ -302,9 +302,9 @@ export class DocumentService
 		}
 		const fluidResolvedUrl = response.resolvedUrl;
 		this._resolvedUrl = fluidResolvedUrl;
-		this.storageUrl = fluidResolvedUrl.endpoints.storageUrl;
-		this.ordererUrl = fluidResolvedUrl.endpoints.ordererUrl;
-		this.deltaStorageUrl = fluidResolvedUrl.endpoints.deltaStorageUrl;
+		this.storageUrl = fluidResolvedUrl.endpoints?.storageUrl;
+		this.ordererUrl = fluidResolvedUrl.endpoints?.ordererUrl;
+		this.deltaStorageUrl = fluidResolvedUrl.endpoints?.deltaStorageUrl;
 		this.deltaStreamUrl = fluidResolvedUrl.endpoints.deltaStreamUrl ?? this.ordererUrl;
 		return true;
 	}

packages/drivers/routerlicious-driver/src/documentServiceFactory.ts

@@ -213,7 +213,7 @@ export class RouterliciousDocumentServiceFactory implements IDocumentServiceFact
 		}
 
 		parsedUrl.pathname = replaceDocumentIdInPath(parsedUrl.pathname, documentId);
-		const deltaStorageUrl = resolvedUrl.endpoints.deltaStorageUrl;
+		const deltaStorageUrl = resolvedUrl.endpoints?.deltaStorageUrl;
 		if (!deltaStorageUrl) {
 			throw new Error(
 				`All endpoints urls must be provided. [deltaStorageUrl:${deltaStorageUrl}]`,
@@ -303,9 +303,9 @@ export class RouterliciousDocumentServiceFactory implements IDocumentServiceFact
 			},
 		);
 
-		const storageUrl = fluidResolvedUrl.endpoints.storageUrl;
-		const ordererUrl = fluidResolvedUrl.endpoints.ordererUrl;
-		const deltaStorageUrl = fluidResolvedUrl.endpoints.deltaStorageUrl;
+		const storageUrl = fluidResolvedUrl.endpoints?.storageUrl;
+		const ordererUrl = fluidResolvedUrl.endpoints?.ordererUrl;
+		const deltaStorageUrl = fluidResolvedUrl.endpoints?.deltaStorageUrl;
 		const deltaStreamUrl = fluidResolvedUrl.endpoints.deltaStreamUrl || ordererUrl; // backward compatibility
 		if (!ordererUrl || !deltaStorageUrl) {
 			throw new Error(

packages/loader/driver-utils/src/test/summaryCompresssionTester.spec.ts

@@ -69,7 +69,7 @@ function generateSummaryWithContent(contentSize: number) {
 				".channels"
 			] as ISummaryTree
 		).tree["7a99532d-94ec-43ac-8a53-d9f978ad4ae9"] as ISummaryTree
-	).tree.header;
+	).tree?.header;
 	let contentString = "";
 	while (contentString.length < contentSize) {
 		if (contentString.length + 10 > contentSize) {
@@ -91,7 +91,7 @@ function generateSummaryWithBinaryContent(startsWith: number, contentSize: numbe
 				".channels"
 			] as ISummaryTree
 		).tree["7a99532d-94ec-43ac-8a53-d9f978ad4ae9"] as ISummaryTree
-	).tree.header;
+	).tree?.header;
 	const content = new Uint8Array(contentSize);
 	content[0] = startsWith;
 	for (let i = 1; i < contentSize; i = i + 10) {
@@ -621,7 +621,7 @@ function getHeaderContent(summary: ISummaryTree) {
 }
 
 function getHeader(summary: ISummaryTree) {
-	return getHeaderHolder(summary).tree.header;
+	return getHeaderHolder(summary).tree?.header;
 }
 
 function getHeaderHolder(summary: ISummaryTree) {

packages/runtime/container-runtime/src/test/containerRuntime.spec.ts

@@ -31,6 +31,7 @@ import {
 	type FetchSource,
 	type IDocumentAttributes,
 	SummaryType,
+	type SummaryObject,
 } from "@fluidframework/driver-definitions/internal";
 import {
 	ISummaryTreeWithStats,
@@ -2093,7 +2094,7 @@ describe("Runtime", () => {
 					false,
 				);
 				const { summary } = await containerRuntime.summarize({ fullTree: true });
-				const blob = summary.tree[recentBatchInfoBlobName];
+				const blob: SummaryObject | undefined = summary.tree[recentBatchInfoBlobName];
 				assert(blob.type === SummaryType.Blob, "Expected blob");
 				assert.equal(blob.content, '[[123,"batchId1"]]', "Expected single batchId mapping");
 
@@ -2423,7 +2424,7 @@ describe("Runtime", () => {
 					["missingDataStore"],
 				);
 				assert.deepStrictEqual(
-					snapshotTree.trees[".channels"].trees.missingDataStore,
+					snapshotTree.trees[".channels"]?.trees.missingDataStore,
 					snapshot.snapshotTree,
 					"snapshot should be equal",
 				);