Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix network tags and depreciated TF for Azure ML. #4246

Merged
merged 3 commits into from
Jan 5, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,8 @@ BUG FIXES:
* Upgrade azurerm terraform provider from v3.112.0 to v3.117.0 to mitiagte storage account deployment issue ([#4004](https://github.com/microsoft/AzureTRE/issues/4004))
* Fix VM actions where Workspace shared storage doesn't allow shared key access ([#4222](https://github.com/microsoft/AzureTRE/issues/4222))
* Fix public exposure in Guacamole service ([[#4199](https://github.com/microsoft/AzureTRE/issues/4199)])
* Fix Azure ML network tags to use name rather than ID ([[#4151](https://github.com/microsoft/AzureTRE/issues/4151)])

COMPONENTS:

## 0.19.1
Expand Down
2 changes: 1 addition & 1 deletion templates/workspace_services/azureml/terraform/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ resource "azurerm_machine_learning_workspace" "aml_workspace" {
ignore_changes = [
tags,
image_build_compute_name,
public_access_behind_virtual_network_enabled
public_network_access_enabled
]
}

Expand Down
2 changes: 1 addition & 1 deletion templates/workspace_services/azureml/terraform/network.tf
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ resource "azurerm_subnet" "aml" {
address_prefixes = [var.address_space]

# need to be disabled for AML private compute
private_endpoint_network_policies_enabled = false
private_endpoint_network_policies = "Disabled"
private_link_service_network_policies_enabled = false

service_endpoints = [
Expand Down
6 changes: 3 additions & 3 deletions templates/workspace_services/azureml/terraform/outputs.tf
Original file line number Diff line number Diff line change
Expand Up @@ -45,13 +45,13 @@ data "azurerm_network_service_tags" "batch_tag" {
}

output "storage_tag" {
value = data.azurerm_network_service_tags.storage_tag.id
value = data.azurerm_network_service_tags.storage_tag.name
}

output "mcr_tag" {
value = data.azurerm_network_service_tags.mcr_tag.id
value = data.azurerm_network_service_tags.mcr_tag.name
}

output "batch_tag" {
value = data.azurerm_network_service_tags.batch_tag.id
value = data.azurerm_network_service_tags.batch_tag.name
}
Loading